Allow new Helm upgrade command to be executed via script #1409
+210
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…helm upgrade command to be executed via bash script
kevjt
commented
Dec 12, 2024
| @@ -77,7 +82,6 @@ public void UsesCustomHelmExecutableFromPackage() | |||
|
|
|||
| var (helm, commandLineRunner, workingDirectory, _) = GetHelmCli(expectedExecutable, new CalamariVariables | |||
| { | |||
| [SpecialVariables.Helm.Packages.CustomHelmExePackageKey] = expectedPackageKey, | |||
There was a problem hiding this comment.
I couldn't find where this variable was being used. The current tests pass even without this here.
kevjt
commented
Dec 12, 2024
| { | ||
| if (isCustomExecutable) | ||
| { | ||
| commandBuilder.Add(syntax == ScriptSyntax.PowerShell ? ". " : $"chmod +x \"{ExecutableLocation}\";"); |
There was a problem hiding this comment.
A lot of this is copied over from https://github.com/OctopusDeploy/Calamari/blob/main/source/Calamari/Kubernetes/Conventions/HelmUpgradeConvention.cs
Co-authored-by: Alastair Pitts <[email protected]>
zentron
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of OctopusDeploy/Issues#9168
The new Helm Upgrade command (introduced as part of the KOS for Helm feature) changed the way Helm was being executed. It was previously being executed via a Bash (or Powershell) script, whereas now the Helm command is being invoked directly with the arguments.
Customers who were using Bash-specific formatting in their arguments, e.g. quotes around literals, have experienced errors in their Helm step as these arguments are no longer being processed by Bash.
This PR introduces a feature-flagged workaround that enables affected customers to continue deploying using the new Helm command by reverting to the script-based deployment method.
[sc-99264]