Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FSharp support #1404

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove FSharp support #1404

wants to merge 4 commits into from

Conversation

APErebus
Copy link
Contributor

FSharp scripts were are deprecated in 2024.1 and thus can be removed in 2025.1.

This PR removes all FSharp code from Calamari. This will be paired with a Server PR that removes all UI for FSharp and also updates Calamari to use this build

Copy link

gitguardian bot commented Dec 12, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
747342 Triggered Generic Password d90d122 source/Calamari.Tests/Fixtures/FSharp/FSharpFixture.cs View secret
747342 Triggered Generic Password d90d122 source/Calamari.Tests/Fixtures/FSharp/FSharpFixture.cs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@APErebus
Copy link
Contributor Author

^ These files are being removed and they are only test data anyway. Not actual secrets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant