Execute app service tests against static app service plans #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APErebus
commented
Oct 14, 2024
| ResourceGroupName, | ||
| new ResourceGroupData(new AzureLocation(ResourceGroupLocation)) | ||
| name, | ||
| new ResourceGroupData(AzureLocation.AustraliaEast) |
There was a problem hiding this comment.
This needs to be AustraliaEast as the static resource groups are in AustraliaEast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have flaky issues in Calamari tests due to capacity issues creating app service plans.
To avoid this, we now have 3 static app service plans that all the test app services are created against. Each test now creates it's own app service against the static plan.
The plans are in the
calamari-testing-static-rgresource group, but the per-test resources are created in their own resource groups, which are torn-down at the end of the test (not test fixture)