Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional LidoSplit Functions #92

Closed
wants to merge 4 commits into from
Closed

Additional LidoSplit Functions #92

wants to merge 4 commits into from

Conversation

samparsky
Copy link
Collaborator

@samparsky samparsky commented Sep 28, 2023 •
edited
Loading

  • Ability to create Easy track motions
  • Ability to add and remove signing keys
  • Ability to make arbitrary custom calls except to the stETH contract address

OisinKyne
OisinKyne approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@OisinKyne OisinKyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests to finish but the code looks good to me.

src/test/lido/LidoSplit.t.sol
Comment on lines +87 to +99
vm.prank();



}

function test_CanRemoveSigningKeys() public {

}

function test_CanCreateETMotions() public {

}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not finished it seems

@samparsky samparsky closed this Oct 9, 2023
@samparsky samparsky deleted the feat/lido-upgrade branch October 19, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OisinKyne OisinKyne OisinKyne approved these changes

Assignees

@samparsky samparsky

Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samparsky @OisinKyne @boulder225