Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Popup" to "New Tab" #68

Open
tobimori opened this issue Nov 20, 2022 · 2 comments
Open

Rename "Popup" to "New Tab" #68

tobimori opened this issue Nov 20, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@tobimori
Copy link
Contributor

This is might be personal nitpicking, but I always see myself renaming "Popup" to "New Tab" as "Popup" is usually kinda confusing and more related to those links that open different browser windows without address bars than those actually wanted by a user if he clicks on an external link.

@hdodov hdodov added the enhancement New feature or request label Nov 20, 2022
@hdodov
Copy link
Contributor

hdodov commented Nov 20, 2022

Couldn't you do this site-wide for all fields as described in the docs, like so:

return [
    'oblik.link-field' => [
        'settings' => [
            'popup' => [
                'label' => 'New Tab'
            ]
        ]
    ]
];

@tobimori
Copy link
Contributor Author

I'm already doing so, I just wanted to open this issue to see what others think of it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants