Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we need integration of H5 family and C0 family #318

Closed
atsju opened this issue Mar 16, 2023 · 6 comments
Closed

we need integration of H5 family and C0 family #318

atsju opened this issue Mar 16, 2023 · 6 comments

Comments

@atsju
Copy link
Collaborator

atsju commented Mar 16, 2023

https://github.com/STMicroelectronics/STM32CubeH5
https://github.com/STMicroelectronics/STM32CubeC0

@xanthio
Copy link
Contributor

xanthio commented Nov 14, 2023

See PR #331 for STM32C0 MCU support

@Hish15 Hish15 closed this as completed Jan 1, 2024
@xanthio
Copy link
Contributor

xanthio commented Jan 1, 2024

@Hish15, thanks for the H5 support.

I guess the unit tests are not executed for these targets as CMakeLists have not been updated.

@atsju
Copy link
Collaborator Author

atsju commented Jan 1, 2024

Seems they are executed. See https://github.com/ObKo/stm32-cmake/actions/runs/7377399007
and

family: [C0, F0, F1, F2, F3, F4, F7, G0, G4, H5, H7, L0, L1, L4, L5, U5, WB, WL, MP1]

@xanthio
Copy link
Contributor

xanthio commented Jan 1, 2024

OK, I didn't notice that family is pre-defined by github workflow.

Nevertheless, I recommend updating the CMakeLists.txt file in each subdirectory on test

if(NOT TEST_FAMILIES)
    set(TEST_FAMILIES C0 F0 F1 F2 F3 F4 F7 G0 G4 H5 H7 L0 L1 L4 L5 MP1 U5 WB WL)
endif()

@atsju
Copy link
Collaborator Author

atsju commented Jan 1, 2024

I agree. Then maybe, we could do something like

set(TEST_FAMILIES L4 F4)
message(warning blabla missing blabla)

to avoid futur omission beeing a problem

@Hish15
Copy link
Collaborator

Hish15 commented Jan 2, 2024

Yes we don't want to manage families as it's done for now on UT. #334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants