From c463efaced347f61fab82c08c0bf65be56b3c104 Mon Sep 17 00:00:00 2001
From: John Harvey <10814889+john681611@users.noreply.github.com>
Date: Mon, 9 Oct 2023 08:44:17 +0100
Subject: [PATCH] GA fix bad links (#417)

Fix bad links in GA (use standard function)
---
 .../frontend/src/pages/GapAnalysis/GapAnalysis.tsx        | 8 +++-----
 application/frontend/src/utils/document.ts                | 2 +-
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/application/frontend/src/pages/GapAnalysis/GapAnalysis.tsx b/application/frontend/src/pages/GapAnalysis/GapAnalysis.tsx
index 87ef58a4f..10b3eff38 100644
--- a/application/frontend/src/pages/GapAnalysis/GapAnalysis.tsx
+++ b/application/frontend/src/pages/GapAnalysis/GapAnalysis.tsx
@@ -18,6 +18,7 @@ import { LoadingAndErrorIndicator } from '../../components/LoadingAndErrorIndica
 import { useEnvironment } from '../../hooks';
 import { GapAnalysisPathStart } from '../../types';
 import { getDocumentDisplayName } from '../../utils';
+import { getInternalUrl } from '../../utils/document';
 
 const GetSegmentText = (segment, segmentID) => {
   let textPart = segment.end;
@@ -66,7 +67,7 @@ const GetResultLine = (path, gapAnalysis, key) => {
   let segmentID = gapAnalysis[key].start.id;
   return (
     <div key={path.end.id} style={{ marginBottom: '.25em', fontWeight: 'bold' }}>
-      <a href={`/node/standard/${path.end.name}/section/${path.end.section}`} target="_blank">
+      <a href={getInternalUrl(path.end)} target="_blank">
         <Popup
           wide="very"
           size="large"
@@ -231,10 +232,7 @@ export const GapAnalysis = () => {
               {Object.keys(gapAnalysis).map((key) => (
                 <Table.Row key={key}>
                   <Table.Cell textAlign="left" verticalAlign="top" selectable>
-                    <a
-                      href={`/node/standard/${gapAnalysis[key].start.name}/section/${gapAnalysis[key].start.section}`}
-                      target="_blank"
-                    >
+                    <a href={getInternalUrl(gapAnalysis[key].start)} target="_blank">
                       <p>
                         <b>{getDocumentDisplayName(gapAnalysis[key].start, true)}</b>
                       </p>
diff --git a/application/frontend/src/utils/document.ts b/application/frontend/src/utils/document.ts
index 1e01d2b35..efafd4c2e 100644
--- a/application/frontend/src/utils/document.ts
+++ b/application/frontend/src/utils/document.ts
@@ -47,7 +47,7 @@ export const groupBy = <T, K extends keyof any>(list: T[], getKey: (item: T) =>
     return previous;
   }, {} as Record<K, T[]>);
 
-export const getInternalUrl = (doc: Document): String => {
+export const getInternalUrl = (doc: Document): string => {
   if (doc.doctype.toLowerCase() != 'cre') {
     var standardAPIPath = `/node/${doc.doctype.toLowerCase()}/${doc.name}/`;
     if (doc) {