Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration from Grunt to npm scripts #149

Open
servatj opened this issue Aug 5, 2019 · 4 comments
Open

Migration from Grunt to npm scripts #149

servatj opened this issue Aug 5, 2019 · 4 comments
Assignees
Milestone

Comments

@servatj
Copy link
Contributor

servatj commented Aug 5, 2019

After looking at the RoadMap 2019 provided by @UlisesGascon. I'm happy to start working on this. I will update this issue with the steps I will follow once I have a bit more context about the status of the project by running it in my local.

@UlisesGascon
Copy link
Collaborator

Thanks @servatj for join us! 🤗

I will update your issue a little bit ;-)

This issue is assigned to you, please remember to refer to it when do you submit a PR, so we can connect the dots easily.

@UlisesGascon UlisesGascon added this to the v1.5 milestone Aug 5, 2019
This was referenced Aug 6, 2019
@servatj
Copy link
Contributor Author

servatj commented Aug 20, 2019

Replace current grunt tasks by npm scripts:

  • Grunt test --> Currently the service has no tests, so we can remove this
  • Grunt ("precommit", ["jsbeautifier", "jshint"]);
  • Grunt test security
  • Grunt precommit , cocncurrent
  • Grunt db-reset
  • Use prettier instead of beautifier
  • Use Eslint instead of jshint

@UlisesGascon

@UlisesGascon
Copy link
Collaborator

I like your approach. In the near future we will add some Unit testing using Jest (I believe).

@servatj
Copy link
Contributor Author

servatj commented Sep 22, 2019

I paste here OLD jshint rules to be reviewed in the future, after we completly remove jshint package and the new eslint package is setup.

{
    "node": true, // Enable globals available when code is running inside of the NodeJS runtime environment.
    "browser": true, // Standard browser globals e.g. `window`, `document`.
    "es5": false, // Allow EcmaScript 5 syntax.
    "esnext": true, // Allow ES.next specific features such as `const` and `let`.
    "bitwise": false, // Prohibit bitwise operators (&, |, ^, etc.).
    "camelcase": true, // Permit only camelcase for `var` and `object indexes`.
    "curly": false, // Require {} for every new block or scope.
    "eqeqeq": true, // Require triple equals i.e. `===`.
    "immed": true, // Require immediate invocations to be wrapped in parens e.g. `( function(){}() );`
    "latedef": true, // Prohibit variable use before definition.
    "newcap": true, // Require capitalization of all constructor functions e.g. `new F()`.
    "noarg": true, // Prohibit use of `arguments.caller` and `arguments.callee`.
    "quotmark": "double", // Define quotes to string values.
    "regexp": true, // Prohibit `.` and `[^...]` in regular expressions.
    "undef": true, // Require all non-global variables be declared before they are used.
    "unused": false, // Warn unused variables.
    "strict": true, // Require `use strict` pragma in every file.
    "trailing": true, // Prohibit trailing whitespaces.
    "smarttabs": false, // Suppresses warnings about mixed tabs and spaces
    "globals": { // Globals variables.
    },
    "predef": [ // Extra globals.
        "define",
        "require",
        "exports",
        "module",
        "describe",
        "before",
        "beforeEach",
        "after",
        "afterEach",
        "it",
        "$",
        "Morris",
        "Tour"
    ],
    "indent": 4, // Specify indentation spacing
    "maxlen": 120, // Max line lenght
    "devel": false, // Allow development statements e.g. `console.log();`.
    "noempty": true // Prohibit use of empty blocks.
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants