Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's improve build steps and include Travis #144

Closed
1 of 4 tasks
UlisesGascon opened this issue Jun 14, 2019 · 7 comments
Closed
1 of 4 tasks

Let's improve build steps and include Travis #144

UlisesGascon opened this issue Jun 14, 2019 · 7 comments

Comments

@UlisesGascon
Copy link
Collaborator

UlisesGascon commented Jun 14, 2019

After the efforts to improve the e2e testing (#142 #143). The next step will be to improve the build steps.

Ideas

What do you think, @ckarande?

@ckarande
Copy link
Member

Love it! It would be a very valuable addition. 👍
We should make a release with these features in and before starting on major refactoring at the code level. Thank you.

@lirantal
Copy link
Collaborator

Sounds great! ✨

I'd advise that we do all of those in their own separate PRs (as smaller units of work as possible) so that we are able to move fast instead of having big-bang PRs that add risk and take a longer time to review.

@UlisesGascon
Copy link
Collaborator Author

Great advise @lirantal! I will generate separare PRs ;-)

@UlisesGascon
Copy link
Collaborator Author

I started to work in the Grunt refactor. Most of the tasks are simple to relocate as npm scripts. But regarding regression and security tests. Right now we are using ZAP, as @binarymist suggested maybe we can use purpleteam.

My approach to this refactor will be to keep grunt only for current security test until we can start the migration to purpleteam if you agree. What do you think @ckarande @lirantal @KoolTheba?

@ckarande
Copy link
Member

I agree. 👍

@lirantal
Copy link
Collaborator

Happy to see how this works out as well. Keep up the great work ✨

@UlisesGascon
Copy link
Collaborator Author

CLose as duplicated in #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants