Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the position of logout modal on page #2943

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

1010varun
Copy link
Contributor

@1010varun 1010varun commented Nov 17, 2024

fixes: #2938 and #2965

I added the flex to make the modal center of the page.

@DonnieBLT
Copy link
Collaborator

Can you make this in the allauth base so it applies to all of the allauth pages?

@1010varun
Copy link
Contributor Author

But @DonnieBLT, don't you think doing this will affect the current alignment of other pages. I think these are correctly aligned currently.

@DonnieBLT
Copy link
Collaborator

No, I think most of the allauth pages are aligned to the left. They could look better.

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have this change be at the base level, so it applies to all the pages in allauth

@1010varun
Copy link
Contributor Author

Surely le me do that

@1010varun
Copy link
Contributor Author

@DonnieBLT made changes in base.html and corrected the alignment of all auth pages

Screenshot from 2024-11-20 00-13-49
Screenshot from 2024-11-20 00-10-56

Screenshot from 2024-11-20 00-11-04

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work with only one file the base file

@1010varun
Copy link
Contributor Author

@DonnieBLT there is a change only in base.html, in logout.html I have made a whole new modal for logout that's why there are changes in that file.

previous logout:
image

changes in logout:

  1. made a box and shadow
  2. changed button color to match the theme
  3. Make text to be in center of modal

Screenshot from 2024-11-20 00-13-49

@DonnieBLT
Copy link
Collaborator

just looking for one file to change here the base.html - that should handle all of the allauth templates

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make it the base.html only - the base.html should go in the allauth or account folder so it overrides the allauth one

@harsh3dev
Copy link

@1010varun still working on this one?

@1010varun
Copy link
Contributor Author

Yess

@1010varun
Copy link
Contributor Author

@DonnieBLT, I think there is some misunderstanding in this PR there are changes in two file:

  1. base.html
  2. Logout.html

the changes in base.html make all the auth pages in the enter of screen and changes in logout.html are done so to create a new modal for logout. Which is another issue(#2965). If you want I can
make changes in base,HTML and then raise another PR for logout modal changes.

I am attaching some ss for new auth screens
Screenshot from 2024-11-20 00-11-04
Screenshot from 2024-11-20 00-13-49
Screenshot from 2024-11-20 00-10-56

@1010varun
Copy link
Contributor Author

@DonnieBLT can you kindly look into this PR

@DonnieBLT
Copy link
Collaborator

Can you show a before and after of the other pages for example change password

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants