-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix the position of logout modal on page #2943
base: main
Are you sure you want to change the base?
Conversation
Can you make this in the allauth base so it applies to all of the allauth pages? |
But @DonnieBLT, don't you think doing this will affect the current alignment of other pages. I think these are correctly aligned currently. |
No, I think most of the allauth pages are aligned to the left. They could look better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have this change be at the base level, so it applies to all the pages in allauth
Surely le me do that |
@DonnieBLT made changes in base.html and corrected the alignment of all auth pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work with only one file the base file
@DonnieBLT there is a change only in base.html, in logout.html I have made a whole new modal for logout that's why there are changes in that file. changes in logout:
|
just looking for one file to change here the base.html - that should handle all of the allauth templates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make it the base.html only - the base.html should go in the allauth or account folder so it overrides the allauth one
@1010varun still working on this one? |
Yess |
@DonnieBLT, I think there is some misunderstanding in this PR there are changes in two file:
the changes in base.html make all the auth pages in the enter of screen and changes in logout.html are done so to create a new modal for logout. Which is another issue(#2965). If you want I can |
@DonnieBLT can you kindly look into this PR |
Can you show a before and after of the other pages for example change password |
fixes: #2938 and #2965
I added the flex to make the modal center of the page.