Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Functionality of Electron Classifier Model and Fake Tracks Model #17

Open
ryansantos1174 opened this issue Dec 7, 2023 · 1 comment · May be fixed by #19
Open

Merge Functionality of Electron Classifier Model and Fake Tracks Model #17

ryansantos1174 opened this issue Dec 7, 2023 · 1 comment · May be fixed by #19
Assignees
@ryansantos1174
Labels
enhancement New feature or request

Comments

@ryansantos1174
Copy link
Contributor

Instead of attempting to develop tools for two seperate networks, we should really attempt to combine the two networks under one interface. I believe this should take the form of a class which is meant to be inherited by both the deepSets and fake track models. After both model are made to inherit the this base class, all tools should then be written such that they work with this base class. By extension, all the tools should then work for all children classes.
@ryansantos1174 ryansantos1174 self-assigned this Dec 7, 2023
@ryansantos1174 ryansantos1174 added the enhancement New feature or request label Dec 7, 2023
@ryansantos1174
Copy link
Contributor Author

ryansantos1174 commented Dec 7, 2023 •
edited
Loading

  • Convert DeepSets network to use NetworkController base class
  • Convert FakeTracks Network to use Network Controller
  • Make GPU submission work with NetworkController class

I will setup a branch based on this issue and ideally a merge request is made to main after each task is done

@ryansantos1174 ryansantos1174 linked a pull request Feb 29, 2024 that will close this issue
17 merge functionality of electron classifier model and fake tracks model #19
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryansantos1174 ryansantos1174

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

17 merge functionality of electron classifier model and fake tracks model OSU-CMS/DisappTrksML
1 participant
@ryansantos1174