Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated preprocess subpackage #1076

Closed
2 tasks done
emiliom opened this issue Jul 17, 2023 · 1 comment
Closed
2 tasks done

Remove deprecated preprocess subpackage #1076

emiliom opened this issue Jul 17, 2023 · 1 comment
Assignees
@emiliom
Labels
tests
Milestone
0.8.0

Comments

@emiliom
Copy link
Collaborator

emiliom commented Jul 17, 2023 •
edited by leewujung
Loading

When we deprecated the preprocess subpackage by moving its functionality into the new commongrid and clean subpackages (see #889), the plan was to remove preprocess with version 0.7.1. Our plan now is to remove it in 0.8.0, which will be released soon.

Also, we inadvertently left "preprocess" in the run-test.py, which led to running many tests twice! I'll submit a PR shortly to address this.
@emiliom emiliom added this to the 0.8.0 milestone Jul 17, 2023
@emiliom emiliom self-assigned this Jul 17, 2023
@emiliom emiliom added this to Echopype Jul 17, 2023
@github-project-automation github-project-automation bot moved this to Todo in Echopype Jul 17, 2023
@emiliom emiliom changed the title Remove deprecated preprocess subpackage Remove deprecated preprocess subpackage Jul 17, 2023
@emiliom emiliom mentioned this issue Jul 17, 2023
Merged
@emiliom emiliom linked a pull request Jul 20, 2023 that will close this issue
Revise qc function to clean up reversed time #1065
Merged
@emiliom emiliom removed a link to a pull request Jul 20, 2023
Revise qc function to clean up reversed time #1065
Merged
@emiliom emiliom mentioned this issue Jul 20, 2023
Merged
@leewujung
Copy link
Member

This can now be closed!

@github-project-automation github-project-automation bot moved this from Todo to Done in Echopype Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emiliom emiliom

Labels
tests
Projects
Echopype
Status: Done
Milestone
0.8.0
Development

No branches or pull requests
2 participants
@emiliom @leewujung