-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Program threw an exception: PARSE_UNKNOWN_KEYWORD #1114
Comments
Thank you for the list of keywords; I guess we can add Json definition files for these keyword, but to support all of them fully in the simulator is a quite significant task. Not clear to me whether that will be prioritized.
Yes it would - the reason we do not do that by default is that the moment you encounter an unknown keyword the parser state becomes fragile, and the risk of further silent errors in the subsequent parsing is quite large. But you can set an environment variable before running flow, which will give this behavior: bash% export OPM_ERRORS_WARN=PARSE_UNKNOWN_KEYWORD
bash% flow CASE.DATA Then you should just get a warning when unknown keywords are encountered, but mind my warning about consecutive problems/errors. |
@joakim-hove If Eclipse does not recognize a keyword then it is an error and the simulation will not run, I would suggest that we do the same as a default, but if OPM Flow recognizes a keyword but does not use it then that should be warning and the simulation should proceed. I agree there are far too many keywords to document, is there a more efficient way to flag these unrecognized keywords without defining the structure and to treat them as errors? Also I tried your suggestions by setting:
I then activated the unrecognized keywords I only got a warning for the MULTNUM, the last offending keyword, what we should have is warning/error messages for all. Also, I'm currently writing the OPM FLow documentation manual, I think it would be better to put all the environment tweaks in the *.parameter file, so that the user only has to edit two files (input deck and the parameter file to run the deck). Is that possible? |
The ParseContext settings could certainly be manipulated through command line parameters (or a .param file), but it would be less flexible -- we would have to choose which particular settings to expose. |
The warnings should go to the PRT file - are you saying that is not the case? |
There is no PRT file or .DEBUG file this instance.
ThunderBird Signature File
Regards, David Baxendale Email: [email protected]
…------------------------------------------------------------------------
On 2017-08-09 16:01, Joakim Hove wrote:
I only got a warning for the MULTNUM, the last offending keyword,
what we should have is warning/error messages for all.
The warnings should go to the PRT file - are you saying that is not
the case?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1114 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ARIIDyXYzuiZzXV5yuB_DxZUVnxeHHbSks5sWWdLgaJpZM4Oxn9r>.
|
OK - @atgeirr : comments? |
Perhaps, if we abort during parsing we might not log/convert the messages from the parser's message container? Just a guess, I have not investigated this. |
Ahhh - that makes sense; the |
Okay, I got passed all the warnings etc. that were printed to the terminal, and OPM Flow appears to run - but it does not as you can see below:
There is no DEBUG or PRT files either. This deck runs under Eclipse and tNavigator without any issues., so it is a good real world test case. I have disabled the ACTION and UDQ associated keywords and made some other modifications to get it to "work". However, without a PRT file I cannot proceed any further. Note I am just testing OPM Flow 's functionality with some real input models. I'll HOLD for now until we have a fix. |
Hmmm - I can not find any of these keywords in the Eclipse100 manual: |
I know not obvious, they are part of the UDQ - User Defined Quantities keywords so look under UDQ and are available for both E100 and E300. This and the ACTION set of keywords are use to "program" Eclipse. The syntax for both ACTION and UDQ keywords is horrible, if we were to add similar functionality to OPM Flow, then I would suggest that we use a ResInsight approach instead; that is just use OCTAVE or R with hooks to OPM Flow. |
Parser threw exceptions for the following keywords:
See the attached file for reference.
PAS-P50-C55.zip
It would be more efficient to to print the keyword and continue rather than abort.
The text was updated successfully, but these errors were encountered: