Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report on MINPV processing #514

Open
joakim-hove opened this issue Feb 16, 2021 · 1 comment
Open

Report on MINPV processing #514

joakim-hove opened this issue Feb 16, 2021 · 1 comment

Comments

@joakim-hove
Copy link
Member

Hello;

I am about to write some code to report on MINPV processing, specifically on the number of cells removed and the volume "lost". This can either be reported where it happens in Minpvprocessor.hpp - or alternatively the details can be exported in a std::vector<....> and logged elsewhere (e.g. opm-simulators). Myself I am inclined to do the last thing - but open for other opinions.

@blattms
Copy link
Member

blattms commented Feb 17, 2021

As long as CpGrid stays usable without too many ecl/opm-isms I am fine.

Would the information be used for anything else besides for logging? If not, why complicate the code. Just add the possibility to pass in a
logger and provide one that does nothing as the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants