Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake is warning about deprecated versions in cmake_minimum_required #10957

Closed
marthinsen opened this issue Dec 14, 2023 · 0 comments · Fixed by #10958
Closed

CMake is warning about deprecated versions in cmake_minimum_required #10957

marthinsen opened this issue Dec 14, 2023 · 0 comments · Fixed by #10958

Comments

@marthinsen
Copy link
Contributor

There are several projects in the Fwk folder that has a minimum required version of 2.8 which CMake warns about. These versions should be updated or simply removed.

Example:

CMake Deprecation Warning at AppFwk/cafPdmCvf/cafPdmCvf_UnitTests/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.
marthinsen added a commit to marthinsen/ResInsight that referenced this issue Dec 14, 2023
@marthinsen
CMake: Update/Remove old minimum version check
a39a3f0 
- Update the minimum required CMake version to 3.15 for Fwk folders
  that might be used as top level projects.
- Remove the minimum required CMake version from projects that is just
  included from other top level projects.

Since version 3.19 CMake has been warning that CMake versions below 3.5
is deprecated and support will be removed in the future. This will
silence those warning.

By removing the minimum required version check from projects that is not
intended as top level projects we avoid redundant checks and simplifies
future maintenance.

Closes OPM#10957
@marthinsen marthinsen mentioned this issue Dec 14, 2023
Merged
magnesj pushed a commit that referenced this issue Dec 16, 2023
@marthinsen @magnesj
CMake: Update/Remove old minimum version check
9701866 
- Update the minimum required CMake version to 3.15 for Fwk folders
  that might be used as top level projects.
- Remove the minimum required CMake version from projects that is just
  included from other top level projects.

Since version 3.19 CMake has been warning that CMake versions below 3.5
is deprecated and support will be removed in the future. This will
silence those warning.

By removing the minimum required version check from projects that is not
intended as top level projects we avoid redundant checks and simplifies
future maintenance.

Closes #10957
@github-actions github-actions bot added the PendingRelease Issues is fixed and will be available in next release label Dec 16, 2023
@magnesj magnesj removed the PendingRelease Issues is fixed and will be available in next release label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CMake: Update/Remove old minimum version check marthinsen/ResInsight
2 participants
@marthinsen @magnesj