Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cafUserInterface relies on QtSvg but doesn't link to it #10955

Closed
marthinsen opened this issue Dec 14, 2023 · 0 comments · Fixed by #10956
Closed

cafUserInterface relies on QtSvg but doesn't link to it #10955

marthinsen opened this issue Dec 14, 2023 · 0 comments · Fixed by #10956

Comments

@marthinsen
Copy link
Contributor

The target cafUserInterface uses QtSvg but doesn't list it as a link dependency, but leaves it to its consumers to do the linking. Shouldn't the target introducing a dependency also be responsible for linking to it?

The targets cafTestApplication, cafTestCvfApplication and cafUserInterface_UnitTests all consumes cafUserInterface and have to manually link to QtSvg as it is today.
marthinsen added a commit to marthinsen/ResInsight that referenced this issue Dec 14, 2023
@marthinsen
Add dependency on QtSvg for project cafUserInterface
2c5d434 
The project cafUserInterface requires the library QtSvg because of the
use of QSvgRenderer in cafUiIconFactory.cpp. The library has to be
linked into the final executable. The target introdicing the dependency
should also be the one specifying it.

This allows us to remove the dependency from targets that doesn't
directly use QtSvg at all.

Closes OPM#10955
@marthinsen marthinsen mentioned this issue Dec 14, 2023
Merged
magnesj pushed a commit that referenced this issue Dec 16, 2023
@marthinsen @magnesj
Add dependency on QtSvg for project cafUserInterface
1f1904d 
The project cafUserInterface requires the library QtSvg because of the
use of QSvgRenderer in cafUiIconFactory.cpp. The library has to be
linked into the final executable. The target introdicing the dependency
should also be the one specifying it.

This allows us to remove the dependency from targets that doesn't
directly use QtSvg at all.

Closes #10955
@github-actions github-actions bot added the PendingRelease Issues is fixed and will be available in next release label Dec 16, 2023
@magnesj magnesj removed the PendingRelease Issues is fixed and will be available in next release label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dependency on QtSvg for project cafUserInterface marthinsen/ResInsight
2 participants
@marthinsen @magnesj