Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback F23 PIN (issue 8, TM): II.2.7.2 and II.2.7.3 a time has been added to the Start and End date #395

Open
valexande opened this issue May 2, 2023 · 4 comments
Assignees
Labels
act: for closing it can be closed but an additional confirmation is needed type: implementation question something needs clarified, refined or decided before the implementation can continue type: missing feature something expected but missing from a release

Comments

@valexande
Copy link
Collaborator

II.2.7.2 and II.2.7.3 a time has been added to the Start and End date

@valexande
Copy link
Collaborator Author

We have removed the time from this property

valexande added a commit that referenced this issue May 7, 2023
@valexande valexande added act: for closing it can be closed but an additional confirmation is needed type: missing feature something expected but missing from a release labels May 9, 2023
@costezki costezki modified the milestones: 2023-05, 2023-planning May 17, 2023
@csnyulas csnyulas added the type: implementation question something needs clarified, refined or decided before the implementation can continue label Jun 9, 2023
@csnyulas
Copy link
Contributor

csnyulas commented Jun 9, 2023

Reopening this issue, as the solution implemented is not as straightforward as it appears to be.

The reason for concatenating the time part 'T00:00:00' after the date, in the first place, was to make the generated value compatible with EPO v3.1.0, where both the start (epo:hasBeginning) and end (epo:hasEnd) of a period is of type xsd:dateTime (and not xsd:date). Perhaps we could have done better by attaching 'T23:59:59' to the end date of the period, instead of 'T00:00:00'.

The problem that @muricna identified is that we can't just add an arbitrary time to the given dates, in order to define a proper moment of the period's start and end, if this is not specified in the input data.

The problem (and te reason for reopening the issue) is that we cannot accurately represent the input according to ePO 3.1.0. We will either:

  1. need to add extra information (for the time part, to be able to type it xsd:dateTime)
  2. receive SHACL shape violations, if we type the given value as ^^xsd:dateTime (as a date value of form "YYYY-MM-DD" is not a valid xsd:dateTime)
  3. receive SHACL shape violations, if we type the given value as ^^xsd:date (as xsd:date is not a subtype of xsd:dateTime)

In our initial implementation we chose option 1. In the fix we chose option 3. As said, neither is perfect.

Questions: Which solution would be the best to go with? If 1, are there more appropriate values to concatenate than the ones that we had originally? Are there other, better, solutions than these 3?

@csnyulas csnyulas reopened this Jun 9, 2023
@muricna
Copy link

muricna commented Jun 12, 2023

A solution has to be found whereby when a time is provided in the xml it is reflected in the rdf. When there is no time in the xml no time should be found in the rdf.

@csnyulas
Copy link
Contributor

Linking this to #269 which provides additional information on the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
act: for closing it can be closed but an additional confirmation is needed type: implementation question something needs clarified, refined or decided before the implementation can continue type: missing feature something expected but missing from a release
Projects
None yet
Development

No branches or pull requests

4 participants