Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback F23 PIN (issue 4, TM): II.2 whole section is wrongly mapped as it is mapped to refersToLot which is the case for the ResultNotice #391

Open
valexande opened this issue May 2, 2023 · 5 comments
Assignees
Labels
type: implementation question something needs clarified, refined or decided before the implementation can continue

Comments

@valexande
Copy link
Collaborator

II.2 According to the ontology CompetitionNotice announcesLot. Therefore this whole section is wrongly mapped as it is mapped to refersToLot which is the case for the ResultNotice.

@csnyulas csnyulas added this to the 2023-05 milestone May 3, 2023
@csnyulas csnyulas added the type: implementation question something needs clarified, refined or decided before the implementation can continue label May 4, 2023
@costezki
Copy link
Collaborator

costezki commented May 4, 2023

We will implement a TripleMap for each class: epo:Notice, epo:CompetitionNotice, epo:ResultNotice

image

@muricna
Copy link

muricna commented May 4, 2023

Be careful note we also have the Contract Modification Notice F20 there is a similar point in the comments of F20

@muricna
Copy link

muricna commented May 4, 2023

We will also need the Planning Notices. However the ontology does not cope with all the relations yet

@csnyulas
Copy link
Contributor

csnyulas commented May 5, 2023

To complement what @costezki said above, this is what we agreed we should do:

We should add the announces/refersTo properties related to both Lot and Procedure not at generic Notice level, but depending on particular subclass of Notices, as the following:

  • epo:CompetitionNotices will use announcesLot and announcesProcedure
  • epo:ResultNotices will use refersToLot and refersToProcedure
  • Currently both epo:PlanningNotices and epo:ContractModificationNotices use refersToLot and refersToProcedure, and we will keep it like that until we find a more appropriate way of deciding what properties would be best in what cases.

@muricna will this solution be correct? Do you think it will work for all the 8 forms that we mapped so far?

On a related note: Regarding Roles, we are always using the epo:announcesRole property, because we realized that it would be extremely difficult to define the (possibly very complicated) conditions that would help identify with certainty the cases where a given role can be simply referred to, as it was (or must have been) announced in some previous notice(s).

@csnyulas
Copy link
Contributor

csnyulas commented May 8, 2023

Also related to #326

@costezki costezki modified the milestones: 2023-05, 2023-planning May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: implementation question something needs clarified, refined or decided before the implementation can continue
Projects
None yet
Development

No branches or pull requests

4 participants