Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conceptual model to show Procedure hasLegalBasis #290

Closed
muricna opened this issue Jan 19, 2023 · 6 comments
Closed

Conceptual model to show Procedure hasLegalBasis #290

muricna opened this issue Jan 19, 2023 · 6 comments
Assignees
Labels
act: for internal discussion type: bug Something implemented incorrectly in a release. type: implementation question something needs clarified, refined or decided before the implementation can continue

Comments

@muricna
Copy link

muricna commented Jan 19, 2023

The conceptual model shows hasLegalBasis with no path though Procedure although the output shows this

@muricna muricna added the type: bug Something implemented incorrectly in a release. label Jan 19, 2023
@csnyulas
Copy link
Contributor

This information has been added at some point as the very first row of the conceptual mapping, with the Field Id called "MetaData", to each form (except for F13, by omission, which has been fixed in v.6.1.2 of the CM, which will be delivered in TX1.4). See screenshot below:

image

We mark this issue as Fixed. If this solution is satisfactory please close the ticket. Otherwise we will close it ourselves if there will be no additional feedback within a few days.

@csnyulas csnyulas added the act: for closing it can be closed but an additional confirmation is needed label Jan 20, 2023
@csnyulas
Copy link
Contributor

csnyulas commented Jan 20, 2023

Here is a related question to this issue:
Currently the value for the epo:hasLegalBasis property comes from the value of the VALUE attribute of the LEGAL_BASIS XML element (as can be seen in the screenshot provided in the previous comment). In recent XSD versions, there is also a LEGAL_BASIS_OTHER XML element available for most (and perhaps all) forms.
Is there anything to be done to map the value of the LEGAL_BASIS_OTHER XML element? Should it be mapped as well? If yes, to what EPO property?

@csnyulas csnyulas self-assigned this Jan 20, 2023
csnyulas added a commit that referenced this issue Jan 20, 2023
…13. The other forms already had this information.
@csnyulas
Copy link
Contributor

Second question:
Should the hasLegalBasis property be attached to the Procedure instance(s) (as it is now), or to the Notice instance?

@csnyulas csnyulas added this to the 2023-01 milestone Jan 27, 2023
@csnyulas
Copy link
Contributor

Decision after discussing the issue with @muricna and @costezki:
epo:hasLegalBasis property takes as a value an IRI from the at-voc:legal-basis vocabulary, based on the value of the LEGAL_BASIS XML element. The values in LEGAL_BASIS_OTHER are of type free text (not controlled in any way), therefore they cannot be mapped to epo:hasLegalBasis property. EPO needs to be extended to allow for the representation of the values in the LEGAL_BASIS_OTHER XML elements. Also, we might want to be able to state information about the legal basis at Procedure level and at document level separately (although with containing the same value), for which we might need to add yet another property in EPO.

For now we will need to make a note in the conceptual mapping stating that the value of the LEGAL_BASIS_OTHER XML element is not going to be mapped until appropriate support for it is provided in EPO. We can do that on the "Mapping Remarks" sheet or in the Notes column of the Rules sheet .

@costezki costezki added type: implementation question something needs clarified, refined or decided before the implementation can continue and removed question labels Jan 30, 2023
@csnyulas
Copy link
Contributor

A note about not being able to map LEGAL_BASIS_OTHER, yet, has been added to the CM, v.6.4.1 (see latest linked commit)

image

We can close this issue as soon as the still open question(s), i.e. the mapping of LEGAL_BASIS_OTHER, and (potentially) what is the best place to attach epo:hasLegalBasis (see #290 (comment)), have been recorded as issue(s) on the EPO project.

@csnyulas
Copy link
Contributor

csnyulas commented Jun 9, 2023

Closing this issue, as the two outstanding questions have been recorded as separate issues:
OP-TED/ePO#448 and #422

@csnyulas csnyulas closed this as completed Jun 9, 2023
@csnyulas csnyulas removed the act: for closing it can be closed but an additional confirmation is needed label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
act: for internal discussion type: bug Something implemented incorrectly in a release. type: implementation question something needs clarified, refined or decided before the implementation can continue
Projects
None yet
Development

No branches or pull requests

4 participants