Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate use of dates vs timestamps for intermediate entity derivation / de-duping logic #74

Open
katy-sadowski opened this issue Oct 5, 2024 · 0 comments

Comments

@katy-sadowski
Copy link
Collaborator

katy-sadowski commented Oct 5, 2024

For example, condition costs are identified via a join on date time right now; maybe this should be date?

AND e.encounter_start_datetime = ca.service_datetime

ETL-Synthea truncates datetimes to dates, so not an issue there. It's possible it doesn't make sense to join on a timestamp. Need to look in the data to confirm.

Also, the issues in #47 turned out to be related to ordering of visit events by date vs datetime.

@katy-sadowski katy-sadowski changed the title Potentially join on date instead of datetime for condition costs Investigate use of dates vs timestamps for intermediate entity derivation / de-duping logic Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant