Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redshift External Table support #363

Open
alondhe opened this issue Jan 6, 2023 · 0 comments
Open

Add Redshift External Table support #363

alondhe opened this issue Jan 6, 2023 · 0 comments

Comments

@alondhe
Copy link

alondhe commented Jan 6, 2023

Is your feature request related to a problem? Please describe.
Redshift external tables cannot be used in WhiteRabbit today, as the step of retrieving table names is based upon using the information_schema: https://github.com/OHDSI/WhiteRabbit/blob/master/rabbit-core/src/main/java/org/ohdsi/databases/RichConnection.java#L160

Describe the solution you'd like
I believe we could add support by having a Redshift specific route that looks at regular and external tables. Something like:

SELECT table_name FROM information_schema.tables WHERE table_schema = 'y202212' union SELECT tablename FROM SVV_EXTERNAL_TABLES where schemaname = 'y202212';

Another approach could be to use the same method as DatabaseConnector, which uses the getTables() java function; this has recently been enhanced by @schuemie to allow for EXTERNAL TABLES: OHDSI/DatabaseConnector#210.

Describe alternatives you've considered
We're going to create regular tables off of the external tables for now.

Tagging my colleague @rfherrerac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant