-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After new database is added in source_daimon it is not shown #1862
Comments
We can add a call to refresh (endpiont: /WebAPI/sources/refresh) after the new source is added. I don't mean to say the client should call /refresh, but rather the function that the endpint points to should be invoked after a new source/source_daimon is added. |
This type of information would be useful to note in the documentation. While it is certainly not ideal to have to restart WebAPI after adding a source, we should note that in the documentation (with a link to this issue) so there is awareness. |
Is it expected for refresh url(/WebAPI/sources/refresh) to return 404 status ? |
No, a 404 shouldn't be returned from /WebAPI/sources/refresh. Per the original issue, now that we have a config screen for sources, it would make sense to have a refresh button for the sources there that calls out to the /WebAPI/sources/refresh endpoint. |
I'd like to do something additional here related to source caching: I'd like it if there was a way to fetch all source info at once so that atlas can request the source list, and have it return one cache, vs. what is happening today (I think) is that atlas queries source info for each source in the list. What's inefficient about this is that each client is hitting the server and doing N (n = number of sources) for the source info. Maye a short term solution is to leverage the caching implementation that is coming in on #2393 and we can cache each individual source info on the server and then if Atlas makes N requests, they will return quickly because the source info is cached. It means that we'll have to de-cache source info on the server under certain circumstances, but we can work out that detail in the issue/PR for that feature. |
So we are caching the data source list now, and the button 'clear server cache' will clear the cache in the event the source is added via INSERTs into the DB. Depends on #2393 |
Expected behavior
When i add a new database to source and source_daimon http://localhost:8080/WebAPI/source/sources would show it and it would be visible in Atlas
Actual behavior
It is not
Steps to reproduce behavior
Add new and test
I tried the refresh under configuration that does not help.
reload the WebAPI in Tomcat solves the problem, this should not be needed
The text was updated successfully, but these errors were encountered: