Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After new database is added in source_daimon it is not shown #1862

Open
PRijnbeek opened this issue Apr 17, 2021 · 6 comments
Open

After new database is added in source_daimon it is not shown #1862

PRijnbeek opened this issue Apr 17, 2021 · 6 comments
Assignees
Labels
documentation Updates to the wiki documentation enhancement
Milestone

Comments

@PRijnbeek
Copy link
Collaborator

Expected behavior

When i add a new database to source and source_daimon http://localhost:8080/WebAPI/source/sources would show it and it would be visible in Atlas

Actual behavior

It is not

Steps to reproduce behavior

Add new and test

I tried the refresh under configuration that does not help.

reload the WebAPI in Tomcat solves the problem, this should not be needed

@chrisknoll
Copy link
Collaborator

We can add a call to refresh (endpiont: /WebAPI/sources/refresh) after the new source is added. I don't mean to say the client should call /refresh, but rather the function that the endpint points to should be invoked after a new source/source_daimon is added.

@anthonysena anthonysena added enhancement documentation Updates to the wiki documentation labels May 3, 2022
@anthonysena
Copy link
Collaborator

This type of information would be useful to note in the documentation. While it is certainly not ideal to have to restart WebAPI after adding a source, we should note that in the documentation (with a link to this issue) so there is awareness.

@davidhcar
Copy link

davidhcar commented Apr 6, 2023

Is it expected for refresh url(/WebAPI/sources/refresh) to return 404 status ?
The updates seen for the url(/WebAPI/source/refresh), that is throwing an exception. but it refreshes the source/daimon tables updates

@chrisknoll chrisknoll added this to the v2.14 milestone Apr 6, 2023
@chrisknoll
Copy link
Collaborator

No, a 404 shouldn't be returned from /WebAPI/sources/refresh. Per the original issue, now that we have a config screen for sources, it would make sense to have a refresh button for the sources there that calls out to the /WebAPI/sources/refresh endpoint.

@chrisknoll chrisknoll moved this from Needs Review to Under Review in Atlas/WebAPI Issue Triage Apr 18, 2023
@chrisknoll chrisknoll moved this from Under Review to Review Complete in Atlas/WebAPI Issue Triage Apr 18, 2023
@anthonysena anthonysena moved this to 🆕 New in Atlas/WebAPI v2.14 Jun 6, 2023
@anthonysena anthonysena moved this from 🆕 New to 🔖 Ready in Atlas/WebAPI v2.14 Jun 6, 2023
@anthonysena anthonysena modified the milestones: v2.14, v2.15 Sep 19, 2023
@anthonysena anthonysena moved this from 🔖 Ready to Pushed To Next Release in Atlas/WebAPI v2.14 Sep 19, 2023
@anthonysena anthonysena moved this to 🆕 New in Atlas/WebAPI v2.15 Nov 21, 2023
@anthonysena anthonysena moved this from 🆕 New to 📋 Backlog in Atlas/WebAPI v2.15 Nov 21, 2023
@chrisknoll chrisknoll self-assigned this Jun 25, 2024
@chrisknoll
Copy link
Collaborator

I'd like to do something additional here related to source caching:

I'd like it if there was a way to fetch all source info at once so that atlas can request the source list, and have it return one cache, vs. what is happening today (I think) is that atlas queries source info for each source in the list. What's inefficient about this is that each client is hitting the server and doing N (n = number of sources) for the source info.

Maye a short term solution is to leverage the caching implementation that is coming in on #2393 and we can cache each individual source info on the server and then if Atlas makes N requests, they will return quickly because the source info is cached. It means that we'll have to de-cache source info on the server under certain circumstances, but we can work out that detail in the issue/PR for that feature.

@chrisknoll
Copy link
Collaborator

So we are caching the data source list now, and the button 'clear server cache' will clear the cache in the event the source is added via INSERTs into the DB. Depends on #2393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Updates to the wiki documentation enhancement
Projects
Status: 📋 Backlog
Status: Review Complete
Status: Pushed To Next Release
Development

No branches or pull requests

5 participants