Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from oracleTempSchema to tempEmulationSchema #126

Closed
schuemie opened this issue May 31, 2021 · 2 comments · Fixed by #270
Closed

Switch from oracleTempSchema to tempEmulationSchema #126

schuemie opened this issue May 31, 2021 · 2 comments · Fixed by #270
Assignees
Milestone

Comments

@schuemie
Copy link
Member

The newer versions of SqlRender and DatabaseConnector have deprecated oracleTempSchema in favor of tempEmulationSchema. Not only is this is rename of the same argument, it now also defaults (in all public function interfaces) to getOption("sqlRenderTempEmulationSchema"). The goal eventually is to no longer require perpetuating this argument through the code but rely on the global option instead.

For FeatureExtraction this means oracleTempSchema needs to be deprecated, and tempEmulationSchema needs to be added to various functions. See this commit in MethodEvaluation for examples of the changes that are required.

@schuemie schuemie assigned schuemie and anthonysena and unassigned schuemie Jan 21, 2022
@anthonysena anthonysena added this to the v4.0.0 milestone Jun 20, 2022
@schuemie
Copy link
Member Author

After a grace period of 4 years, oracleTempSchema is about to be completely removed. Please make sure FeatureExtraction switches to tempEmulationSchema at the nearest opportunity. See OHDSI/DatabaseConnector#289

@anthonysena
Copy link
Collaborator

Moving this to the v3.7.0 milestone since the addition of the tempEmulationSchema maintains backwards compatibility. We'll then use #159 to remove the oracleTempSchema in the v4.0 release.

@ginberg ginberg closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants