Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exported odbc classes #263

Open
hadley opened this issue Dec 12, 2023 · 1 comment
Open

Use exported odbc classes #263

hadley opened this issue Dec 12, 2023 · 1 comment

Comments

@hadley
Copy link

hadley commented Dec 12, 2023

The dev version of odbc exports the classes it defines, so once it's on CRAN you can use them, rather than redefining yourself (

class_cache <- new.env(parent = emptyenv())
# Simple class prototype to avoid messages about unknown classes from setMethod
setClass("Microsoft SQL Server", where = class_cache)
setClass("DatabaseConnectorConnection", where = class_cache)
setClass("DatabaseConnectorJdbcConnection", where = class_cache)
setClass("DatabaseConnectorDbiConnection", where = class_cache)
). This will avoid conflicting classes definition between odbc and DatabaseConnector.

@schuemie
Copy link
Member

Thanks! I think this fits nicely with our new development to use dbplyr backends for the various data platforms @ablack3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants