Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernizing the Build System #2777

Open
4 tasks
robertmclaws opened this issue Apr 27, 2023 · 2 comments
Open
4 tasks

Modernizing the Build System #2777

robertmclaws opened this issue Apr 27, 2023 · 2 comments
Assignees

Comments

@robertmclaws
Copy link
Collaborator

robertmclaws commented Apr 27, 2023

The 7x branch of OData is still leveraging the old C# project system to build .NET Framework projects. This process leads to numerous issues when releasing OData libraries, including compiled versions being out of sync with packaged versions.

This set of changes that will follow in a PR will update the process to build .NET Framework & .NET Core out of the same solution, and will require the CI/CD process to be upgraded as well.

When finished, OData 7x will match the structure of the Restier project, which has demonstrated the benefits of using this system for several releases now.

Questions to be answered:

  • Should we drop StyleCop (YES!!!)
  • Should we drop skipping strong names (YES!!!)
  • Should we drop the extra .targets files (YES!!!)
  • Should we be pointing to the MIT license instead of using our own license file? (YES!!!)
@KenitoInc
Copy link
Contributor

What will we be replacing stylecop with?

@robertmclaws
Copy link
Collaborator Author

Visual Studio 2022 has many if not most of StyleCop's features built into .editorConfig files. It does not need to be enforced in the build process as it is not currently directly improving release quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants