Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gnuplot snippet #9

Merged
merged 3 commits into from
Sep 15, 2023
Merged

feat: add gnuplot snippet #9

merged 3 commits into from
Sep 15, 2023

Conversation

sanjayankur31
Copy link
Collaborator

Adds a snippet about how to quickly plot on the command line using GNUPlot.

@sanjayankur31 sanjayankur31 requested a review from a team September 13, 2023 14:59
@sanjayankur31 sanjayankur31 added documentation Improvements or additions to documentation T: enhancement New feature or request good first issue Good for newcomers labels Sep 13, 2023
Now we can have parts like "python" and so on, to organize snippets
better
Copy link
Collaborator

@mstimberg mstimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

A minor nitpick: I think

```bash
$ ...
```

should be

```console
$ ....
```

otherwise, the numbers at the start of the lines get highlighted in a confusing way. Somewhere between sphinx/pygments/myst/… the proper highlighting with a different color for the $ gets lost – it looks fine in the PDF, though 🤷‍♂️

I also wonder, whether we should do something about the long lines that get cut off – would line continuation with \ be helpful or confusing?

@sanjayankur31
Copy link
Collaborator Author

I've updated it to console and broken the long lines too. I think breaking them is fine---the commands here aren't that complex so it's kind of obvious what is being done.

Copy link
Collaborator

@mstimberg mstimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mstimberg mstimberg merged commit 0826f87 into main Sep 15, 2023
1 check passed
@mstimberg mstimberg deleted the feat/gnuplot branch September 15, 2023 12:06
@mstimberg
Copy link
Collaborator

@all-contributors please add @mstimberg for review

@allcontributors
Copy link
Contributor

@mstimberg

I've put up a pull request to add @mstimberg! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers T: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants