From aaefadd3b9990d91577bd678160fcdec7d80a108 Mon Sep 17 00:00:00 2001 From: Alexandru Artimon Date: Sat, 8 Jun 2024 16:37:08 +0000 Subject: [PATCH] HDX-9070 - Discovery - Google Search Console - Core Web Vitals - Prepare for March 2024 - remove "empty.css" from webassets - remove lazy loading from carousel as now there are few items and is the largest section impacting the "Largest Contentful Paint", so we want the browser to prioritize loading the images - removed signup + verify popups from page template as they have been moved to a separate page - use
- Highlight item + Highlight item
{% if item.embed %} {% endblock %} {% set CONST = h.HDX_CONST('UI_CONSTANTS')['ONBOARDING']['USER_INFO'] %} diff --git a/ckanext-hdx_theme/ckanext/hdx_theme/templates/page.html b/ckanext-hdx_theme/ckanext/hdx_theme/templates/page.html index 888ef29392..188517e3b1 100644 --- a/ckanext-hdx_theme/ckanext/hdx_theme/templates/page.html +++ b/ckanext-hdx_theme/ckanext/hdx_theme/templates/page.html @@ -55,8 +55,8 @@ {% else %} {{ h.snippet('widget/onboarding/logout.html', id="logoutPopup")}} {# {{ h.snippet('widget/onboarding/login.html', id="loginPopup", login_came_from=data.login_came_from if data else None) }}#} - {{ h.snippet('widget/onboarding/signup.html', id="signupPopup") }} - {{ h.snippet('widget/onboarding/verify.html', id="verifyPopup") }} +{# {{ h.snippet('widget/onboarding/signup.html', id="signupPopup") }} + {{ h.snippet('widget/onboarding/verify.html', id="verifyPopup") }} #} {% endif %} {{ h.snippet('widget/onboarding/survey.html', id="surveyPopup") }} @@ -223,7 +223,8 @@ {# {% if g.tracking_enabled %}#} {# {% resource 'hdx_theme/package/tracking.js' %}#} {# {% endif %}#} - + + {##} {{ super() }} {% asset 'hdx_theme/search-scripts' %} {% if c.userobj %} diff --git a/ckanext-hdx_theme/ckanext/hdx_theme/templates/page_light.html b/ckanext-hdx_theme/ckanext/hdx_theme/templates/page_light.html index c7f02efa05..15fc8d0a42 100644 --- a/ckanext-hdx_theme/ckanext/hdx_theme/templates/page_light.html +++ b/ckanext-hdx_theme/ckanext/hdx_theme/templates/page_light.html @@ -119,7 +119,8 @@ {# {% if g.tracking_enabled %}#} {# {% resource 'hdx_theme/package/tracking.js' %}#} {# {% endif %}#} - + + {##} {{ super() }} {% if c.userobj %} {% set data = h.get_user_extra(c.userobj.id) %} diff --git a/ckanext-hdx_theme/ckanext/hdx_theme/templates/user/forgot_password.html b/ckanext-hdx_theme/ckanext/hdx_theme/templates/user/forgot_password.html index a1461f40cf..b507ff8d33 100644 --- a/ckanext-hdx_theme/ckanext/hdx_theme/templates/user/forgot_password.html +++ b/ckanext-hdx_theme/ckanext/hdx_theme/templates/user/forgot_password.html @@ -4,7 +4,6 @@ {% block styles %} {{ super() }} {% asset 'hdx_theme/page-styles' %} - {% asset 'hdx_theme/onboarding-styles' %} {% asset 'requestdata/main-styles' %} {% asset 'hdx_theme/onboarding-password-styles' %} {% endblock %} diff --git a/ckanext-hdx_theme/ckanext/hdx_theme/templates/user/signin.html b/ckanext-hdx_theme/ckanext/hdx_theme/templates/user/signin.html index 32c3675bef..26bfec363e 100644 --- a/ckanext-hdx_theme/ckanext/hdx_theme/templates/user/signin.html +++ b/ckanext-hdx_theme/ckanext/hdx_theme/templates/user/signin.html @@ -4,8 +4,6 @@ {% block styles %} {{ super() }} {% asset 'hdx_theme/page-styles' %} - {% asset 'hdx_theme/onboarding-styles' %} - {% asset 'hdx_theme/onboarding-password-styles' %} {% asset 'hdx_theme/signin-styles' %} {% endblock %} diff --git a/ckanext-hdx_theme/ckanext/hdx_theme/templates/widget/onboarding/data-use-survey.html b/ckanext-hdx_theme/ckanext/hdx_theme/templates/widget/onboarding/data-use-survey.html index 0f1241926b..31ec255bcf 100644 --- a/ckanext-hdx_theme/ckanext/hdx_theme/templates/widget/onboarding/data-use-survey.html +++ b/ckanext-hdx_theme/ckanext/hdx_theme/templates/widget/onboarding/data-use-survey.html @@ -8,7 +8,6 @@ {{ h.snippet('widget/onboarding/done.html', id="donePopup") }} #} {#{% resource 'hdx_theme/widget/onboarding/survey.css' %}#} -{% asset 'hdx_theme/onboarding-survey-styles' %} {% set class = "popup-onbording" %} {% set title = "HDX Data Use Survey" %} diff --git a/ckanext-hdx_theme/ckanext/hdx_theme/templates/widget/onboarding/survey.html b/ckanext-hdx_theme/ckanext/hdx_theme/templates/widget/onboarding/survey.html index 9212e909ba..5c3cc08d60 100644 --- a/ckanext-hdx_theme/ckanext/hdx_theme/templates/widget/onboarding/survey.html +++ b/ckanext-hdx_theme/ckanext/hdx_theme/templates/widget/onboarding/survey.html @@ -7,8 +7,6 @@ Example: {{ h.snippet('widget/onboarding/done.html', id="donePopup") }} #} -{#{% resource 'hdx_theme/widget/onboarding/survey.css' %}#} -{% asset 'hdx_theme/onboarding-survey-styles' %} {% set class = "popup-onbording" %} {% set title = "Data Literacy Survey" %}