From 2d4b625f1cdcf41e7fa0bb46ceba7e49a67e273d Mon Sep 17 00:00:00 2001
From: Alexandru Artimon <aalecs@gmail.com>
Date: Thu, 27 Jun 2024 14:40:58 +0000
Subject: [PATCH] HDX-9070 - Discovery - Google Search Console - Core Web
 Vitals - Prepare for March 2024          - load fontawesome from CDN instead
 of CKAN

---
 .../ckanext/hdx_theme/fanstatic/webassets.yml         | 11 +++++------
 .../ckanext/hdx_theme/templates/page.html             |  1 +
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/ckanext-hdx_theme/ckanext/hdx_theme/fanstatic/webassets.yml b/ckanext-hdx_theme/ckanext/hdx_theme/fanstatic/webassets.yml
index fcee391451..0fb652a47b 100644
--- a/ckanext-hdx_theme/ckanext/hdx_theme/fanstatic/webassets.yml
+++ b/ckanext-hdx_theme/ckanext/hdx_theme/fanstatic/webassets.yml
@@ -4,11 +4,10 @@ common-js: &common-js
 common-css: &common-css
   filters: cssrewrite, rcssmin
 
-vendor-vendor-css:
-  <<: *common-css
-  output: ckanext-hdx_theme/%(version)s_vendor-vendor.css
-  contents:
-    - vendor/fontawesome-free/css/all.css    
+# vendor-vendor-css:
+#   contents:
+    #same version as CKANs but from CDN and min
+    # Fontawesome is included directly in page.html
 
 vendor-vendor:
   #original is base/vendor/webassets.yml -> vendor
@@ -109,7 +108,7 @@ page-styles:
   output: ckanext-hdx_theme/%(version)s_page-styles.css
   <<: *common-css
   contents:
-    - vendor-vendor-css
+    # - vendor-vendor-css - Fontawesome is included directly in page.html
     - select2/select2.css
     - page-common-styles
     - base/base.css
diff --git a/ckanext-hdx_theme/ckanext/hdx_theme/templates/page.html b/ckanext-hdx_theme/ckanext/hdx_theme/templates/page.html
index 188517e3b1..62102ec7aa 100644
--- a/ckanext-hdx_theme/ckanext/hdx_theme/templates/page.html
+++ b/ckanext-hdx_theme/ckanext/hdx_theme/templates/page.html
@@ -224,6 +224,7 @@
 {#      {% resource 'hdx_theme/package/tracking.js' %}#}
 {#  {% endif %}#}
   <link rel=preconnect href="https://fonts.gstatic.com" />
+  <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.5.1/css/all.min.css" integrity="sha512-DTOQO9RWCH3ppGqcWaEA1BIZOC6xxalwEsw9c2QQeAIftl+Vegovlnee1c9QX4TctnWMn13TZye+giMm8e2LwA==" crossorigin="anonymous" referrerpolicy="no-referrer" />
   {#<script src="https://www.google.com/recaptcha/api.js" async defer></script>#}
   {{ super() }}
   {% asset 'hdx_theme/search-scripts' %}