Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] disable_odoo_online: Migration to 18.0 #89

Open
wants to merge 34 commits into
base: 18.0
Choose a base branch
from

Conversation

PauMAVA
Copy link

@PauMAVA PauMAVA commented Nov 8, 2024

tungocbui and others added 30 commits November 8, 2024 13:30
…. Update the version in the file __openerp__.py
…n. (#583)

* [PORT] disable_odoo_online. [REF] remove obsolete code. OCA convention.

* [FIX] restauring old feature

* [IMP] do not disable some feature for Enterprise Edition. [REF] some improvements
…doo community only (OCA#4)

* [DOC] disable_odoo_online: clarify docs

-- one of the features is applied only in odoo community
* [REF] Changes template used to modificate user preferences menu
* [IMP] Includes app menu from settings in technical parameters menu
Currently translated at 100.0% (1 of 1 strings)

Translation: server-brand-12.0/server-brand-12.0-disable_odoo_online
Translate-URL: https://translation.odoo-community.org/projects/server-brand-12-0/server-brand-12-0-disable_odoo_online/fr/
Currently translated at 100.0% (1 of 1 strings)

Translation: server-brand-12.0/server-brand-12.0-disable_odoo_online
Translate-URL: https://translation.odoo-community.org/projects/server-brand-12-0/server-brand-12-0-disable_odoo_online/es/
Currently translated at 100.0% (1 of 1 strings)

Translation: server-brand-12.0/server-brand-12.0-disable_odoo_online
Translate-URL: https://translation.odoo-community.org/projects/server-brand-12-0/server-brand-12-0-disable_odoo_online/pt_BR/
Currently translated at 100.0% (1 of 1 strings)

Translation: server-brand-12.0/server-brand-12.0-disable_odoo_online
Translate-URL: https://translation.odoo-community.org/projects/server-brand-12-0/server-brand-12-0-disable_odoo_online/hr/
[FIX] pre-commit

[FIX] Remove use of api.multi

[FIX] pre-commit

[FIX] pre-commit

[FIX] pre-commit

[FIX] pre-commit
Currently translated at 100.0% (1 of 1 strings)

Translation: server-brand-15.0/server-brand-15.0-disable_odoo_online
Translate-URL: https://translation.odoo-community.org/projects/server-brand-15-0/server-brand-15-0-disable_odoo_online/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-brand-16.0/server-brand-16.0-disable_odoo_online
Translate-URL: https://translation.odoo-community.org/projects/server-brand-16-0/server-brand-16-0-disable_odoo_online/
OCA-git-bot and others added 3 commits November 8, 2024 13:30
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-brand-17.0/server-brand-17.0-disable_odoo_online
Translate-URL: https://translation.odoo-community.org/projects/server-brand-17-0/server-brand-17-0-disable_odoo_online/
@pedrobaeza
Copy link
Member

/ocabot migration disable_odoo_online

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Nov 8, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 8, 2024
3 tasks
@pedrobaeza
Copy link
Member

Please check CI

@PauMAVA
Copy link
Author

PauMAVA commented Nov 8, 2024

Buenas @pedrobaeza faltan tests tanto en disable_odoo_online como en portal_odoo_debranding.

WARNING odoo odoo.tests.result: 0 failed, 0 error(s) of 0 tests when loading database 'odoo' 

Tampoco había en la 17.0.

Miro de implementar algunos.

@pedrobaeza
Copy link
Member

Please talk in this international repo in English. We can talk in Spanish in OCA/l10n-spain.

Yeah, now the warnings give red in CI. You can add a dummy test in this case as a workaround.

@PauMAVA
Copy link
Author

PauMAVA commented Nov 8, 2024

Quick question, I see the new PWA menu and also config section. I don't see any reference to it being part of enterprise and It fully works as expected. At the same time I know there is the OCA PWA repo the OCA PWA will then be deprecated?

imagen
imagen
imagen

In this case we should obviously not hide the PWA features. I will remove this line that I previously added:

registry.category("user_menuitems").remove("install_pwa");

@pedrobaeza
Copy link
Member

Yes, PWA is something that shouldn't be hidden.

@PauMAVA PauMAVA force-pushed the 18.0-mig-disable_odoo_online branch from 083adf5 to 546c40a Compare November 8, 2024 17:23
@PauMAVA
Copy link
Author

PauMAVA commented Nov 8, 2024

Dummy tests as a workaround implemented in both disable_odoo_online and portal_odoo_debranding PRs.

Copy link

@houssine78 houssine78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.