[14.0][FIX][IMP] base_user_role_profile : add the missing swiching widget, add new options to further improve the usability #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypapouin
suggested changes
Oct 7, 2024
Comment on lines
12
to
13
| aria-label="Dropdown menu" | ||
| title="Dropdown menu" |
There was a problem hiding this comment.
aria-label="Switch profile"
title="Switch profile"
ypapouin
approved these changes
Oct 8, 2024
ypapouin
pushed a commit
to decgroupe/server-backend
that referenced
this pull request
Oct 14, 2024
…he missing swiching widget, add new options to further improve the usability
kevinkhao
approved these changes
Oct 22, 2024
|
This PR has the |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-backend
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-backend (14.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the USAGE.rst the
base_user_role_profilemodule is supposed to allow a user to switch between 'role profiles' that are allowed to he or she, which are basically a way of adding or removing roles depending on the profile, therefore dynamically changing the user's rights.Unfortunately the switching widget allowing the user to do so was removed from the module.
This PR put it back, with some fixes, and add new options to allow a bit more flexibility in it's use.
Some tests we added too.