From 7a5ff390949f8a461212c00e50b0fdbae5bca7d6 Mon Sep 17 00:00:00 2001
From: Antoni Marroig Campomar <amarroig@apsl.net>
Date: Tue, 12 Nov 2024 11:39:48 +0100
Subject: [PATCH] [IMP] rma: pre-commit auto fixes

---
 rma/data/mail_data.xml                  | 25 +++++++++--------
 rma/models/rma.py                       |  2 +-
 rma/views/res_config_settings_views.xml | 36 +++++++++++--------------
 rma/views/rma_portal_templates.xml      | 12 ++++-----
 rma/views/rma_team_views.xml            | 14 +++++-----
 rma/views/rma_views.xml                 |  6 ++---
 6 files changed, 43 insertions(+), 52 deletions(-)

diff --git a/rma/data/mail_data.xml b/rma/data/mail_data.xml
index 79d0d22f4..a4ac58a8e 100644
--- a/rma/data/mail_data.xml
+++ b/rma/data/mail_data.xml
@@ -31,7 +31,6 @@
         <field name="relation_field">team_id</field>
     </record>
 
-
     <!--RMA email template -->
     <record id="mail_template_rma_notification" model="mail.template">
         <field name="name">RMA Notification</field>
@@ -50,14 +49,14 @@
                     Dear
                     <t t-out="object.partner_id.name" />
                     <t t-if="object.partner_id.parent_id">
-                        <t t-out="object.partner_id.parent_id.name" />
-                    </t>
+                    <t t-out="object.partner_id.parent_id.name" />
+                </t>
                     <br />
                     <br />
                     Here is the RMA
                     <strong>
-                        <t t-out="object.name" />
-                    </strong>
+                    <t t-out="object.name" />
+                </strong>
                     from
                     <t t-out="object.company_id.name" />
                     .
@@ -86,14 +85,14 @@
                     Dear
                     <t t-out="object.partner_id.name" />
                     <t t-if="object.partner_id.parent_id">
-                        <t t-out="object.partner_id.parent_id.name" />
-                    </t>
+                    <t t-out="object.partner_id.parent_id.name" />
+                </t>
                     <br />
                     <br />
                     The products for your RMA
                     <strong>
-                        <t t-out="object.name" />
-                    </strong>
+                    <t t-out="object.name" />
+                </strong>
                     from
                     <t t-out="object.company_id.name" />
                     have been received in our warehouse.
@@ -121,14 +120,14 @@
                     Dear
                     <t t-out="object.partner_id.name" />
                     <t t-if="object.partner_id.parent_id">
-                        <t t-out="object.partner_id.parent_id.name" />
-                    </t>
+                    <t t-out="object.partner_id.parent_id.name" />
+                </t>
                     <br />
                     <br />
                     You've succesfully placed your RMA
                     <strong>
-                        <t t-out="object.name" />
-                    </strong>
+                    <t t-out="object.name" />
+                </strong>
                     on
                     <t t-out="object.company_id.name" />
                     . Our team will check it and will validate it as soon as possible.
diff --git a/rma/models/rma.py b/rma/models/rma.py
index 124f2c2ad..42fca5eb2 100644
--- a/rma/models/rma.py
+++ b/rma/models/rma.py
@@ -1303,7 +1303,7 @@ def _message_get_suggested_recipients(self):
     # Reporting business methods
     def _get_report_base_filename(self):
         self.ensure_one()
-        return "RMA Report - %s" % self.name
+        return f"RMA Report - {self.name}"
 
     # Other business methods
 
diff --git a/rma/views/res_config_settings_views.xml b/rma/views/res_config_settings_views.xml
index a887024d1..6944e6e65 100644
--- a/rma/views/res_config_settings_views.xml
+++ b/rma/views/res_config_settings_views.xml
@@ -12,42 +12,39 @@
                     title="Finish RMAs manually"
                     help=" When the RMA is receive, allow to finsish it manually choosing a finalization reason."
                 >
-                        <field name="group_rma_manual_finalization" />
+                    <field name="group_rma_manual_finalization" />
                 </setting>
                 <setting
                     title="Values set here are company-specific."
                     help="Group RMA returns by customer and warehouse."
                 >
-                        <field name="rma_return_grouping" />
+                    <field name="rma_return_grouping" />
                 </setting>
                 <setting
                     title="Send automatic RMA info to customer"
                     help="When the RMA is confirmed, send an automatic information email."
                 >
-                        <field name="send_rma_confirmation" />
-                        <div class="row mt16" invisible="not send_rma_confirmation">
-                            <label
+                    <field name="send_rma_confirmation" />
+                    <div class="row mt16" invisible="not send_rma_confirmation">
+                        <label
                             for="rma_mail_confirmation_template_id"
                             string="Email Template"
                             class="col-lg-4 o_light_label"
                         />
-                            <field
+                        <field
                             name="rma_mail_confirmation_template_id"
                             class="oe_inline"
                             required="send_rma_confirmation"
                             context="{'default_model': 'rma'}"
                         />
-                        </div>
+                    </div>
                 </setting>
                 <setting
                     title="Send automatic RMA products reception notification to customer"
                     help="When the RMA products are received, send an automatic information email."
                 >
-                        <field name="send_rma_receipt_confirmation" />
-                        <div
-                        class="row mt16"
-                        invisible="not send_rma_receipt_confirmation"
-                    >
+                    <field name="send_rma_receipt_confirmation" />
+                    <div class="row mt16" invisible="not send_rma_receipt_confirmation">
                         <label
                             for="rma_mail_receipt_confirmation_template_id"
                             string="Email Template"
@@ -60,29 +57,26 @@
                             required="send_rma_receipt_confirmation"
                             context="{'default_model': 'rma'}"
                         />
-                        </div>
+                    </div>
                 </setting>
                 <setting
                     title="Send automatic notification when the customer places an RMA"
                     help="When customers themselves place an RMA from the portal, send an automatic notification acknowleging it."
                 >
-                        <field name="send_rma_draft_confirmation" />
-                        <div
-                        class="row mt16"
-                        invisible="not send_rma_draft_confirmation"
-                    >
-                            <label
+                    <field name="send_rma_draft_confirmation" />
+                    <div class="row mt16" invisible="not send_rma_draft_confirmation">
+                        <label
                             for="rma_mail_draft_confirmation_template_id"
                             string="Email Template"
                             class="col-lg-4 o_light_label"
                         />
-                            <field
+                        <field
                             name="rma_mail_draft_confirmation_template_id"
                             class="oe_inline"
                             required="send_rma_draft_confirmation"
                             context="{'default_model': 'rma'}"
                         />
-                        </div>
+                    </div>
                 </setting>
             </xpath>
         </field>
diff --git a/rma/views/rma_portal_templates.xml b/rma/views/rma_portal_templates.xml
index 7c56d9425..ed82652e3 100644
--- a/rma/views/rma_portal_templates.xml
+++ b/rma/views/rma_portal_templates.xml
@@ -414,9 +414,9 @@
                                 <div class="d-lg-inline-block">
                                     Date:
                                     <span
-                                        class="text-muted"
-                                        t-field="refund.invoice_date"
-                                    />
+                                    class="text-muted"
+                                    t-field="refund.invoice_date"
+                                />
                                 </div>
                             </div>
                             <span
@@ -466,9 +466,9 @@
                                         <div class="d-lg-inline-block">
                                             Date:
                                             <span
-                                                class="text-muted"
-                                                t-field="picking.date"
-                                            />
+                                            class="text-muted"
+                                            t-field="picking.date"
+                                        />
                                         </div>
                                     </div>
                                     <t t-if="picking.state == 'done'">
diff --git a/rma/views/rma_team_views.xml b/rma/views/rma_team_views.xml
index 0ae66c788..49a1c76e3 100644
--- a/rma/views/rma_team_views.xml
+++ b/rma/views/rma_team_views.xml
@@ -97,13 +97,13 @@
                                         style="display: inline;"
                                     >
                                         <field
-                                            name="alias_name"
-                                            class="oe_inline"
-                                        />@<field
-                                            name="alias_domain"
-                                            class="oe_inline"
-                                            readonly="1"
-                                        />
+                                        name="alias_name"
+                                        class="oe_inline"
+                                    />@<field
+                                        name="alias_domain"
+                                        class="oe_inline"
+                                        readonly="1"
+                                    />
                                     </div>
                                 </div>
                                 <field
diff --git a/rma/views/rma_views.xml b/rma/views/rma_views.xml
index 5fe316095..2d8f10b43 100644
--- a/rma/views/rma_views.xml
+++ b/rma/views/rma_views.xml
@@ -204,8 +204,7 @@
                             class="oe_stat_button"
                             icon="fa-truck"
                             invisible="not reception_move_id"
-                        >
-                        </button>
+                        />
                         <button
                             type="object"
                             name="action_view_delivery"
@@ -226,8 +225,7 @@
                             class="oe_stat_button"
                             icon="fa-pencil-square-o"
                             invisible="not refund_id"
-                        >
-                        </button>
+                        />
                     </div>
                     <div class="oe_title">
                         <h1>