[15.0][FIX] base_multi_company: search with in operator #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pedrobaeza, |
pedrobaeza
approved these changes
Nov 18, 2024
carlosdauden
approved these changes
Nov 18, 2024
When searching the company with a domain like [("company_id", "in", [1,
False]) to include records which are shared between companies we won't
get those with no companies at all. That will lead to logical errors in
several workflows.
TT51779
chienandalu
force-pushed
the
15.0-fix-base_multi_company-search-in-company_id
branch
from
0c85e87
to
7ed5468
Compare
victoralmau
approved these changes
Nov 19, 2024
Done |
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 1a4e063. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
15.0-fix-base_multi_company-search-in-company_id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When searching the company with a domain like [("company_id", "in", [1, False]) to include records which are shared between companies we won't get those with no companies at all. That will lead to logical errors in several workflows.
cc @Tecnativa TT51779
please review @pedrobaeza @carlosdauden