Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] purchase_sale_lot_intercompany #510

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

Kev-Roche
Copy link
Contributor

Migration of the PR: #481

@legalsylvain
Copy link
Contributor

Hi @Kev-Roche. Thanks for porting this module. could you take a look on red CI ?

thanks !

@legalsylvain legalsylvain added this to the 16.0 milestone Dec 17, 2023
@Kev-Roche Kev-Roche force-pushed the 16.0-add-purchase_sale_lot_intercompany branch 4 times, most recently from c56040e to 1cbfdbd Compare January 30, 2024 20:50
@Kev-Roche Kev-Roche force-pushed the 16.0-add-purchase_sale_lot_intercompany branch from 1cbfdbd to becbb51 Compare May 1, 2024 10:42
@metaminux
Copy link
Contributor

Hi @sbidoul
Tests were canceled on this PR, can we launch it again ?

@sbidoul
Copy link
Member

sbidoul commented May 3, 2024

@metaminux please rebase and git push --force-with-lease

Copy link

github-actions bot commented Sep 1, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 1, 2024
@metaminux
Copy link
Contributor

@Kev-Roche Can you please rebase and force push as @sbidoul stated ?

@Kev-Roche Kev-Roche force-pushed the 16.0-add-purchase_sale_lot_intercompany branch from becbb51 to 265f984 Compare September 11, 2024 17:33
@Kev-Roche Kev-Roche force-pushed the 16.0-add-purchase_sale_lot_intercompany branch from 265f984 to f3ba826 Compare September 11, 2024 17:34
Comment on lines +5 to +7
from odoo.addons.purchase_sale_stock_inter_company.tests.test_inter_company_purchase_sale_stock import (
TestPurchaseSaleStockInterCompany,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kev-Roche

To avoid the conflict between black, isort and flake8 on the line length for python import, I think the least worst solution is :

Suggested change
from odoo.addons.purchase_sale_stock_inter_company.tests.test_inter_company_purchase_sale_stock import (
TestPurchaseSaleStockInterCompany,
)
from odoo.addons.purchase_sale_stock_inter_company.tests.test_inter_company_purchase_sale_stock import ( # noqa: B950
TestPurchaseSaleStockInterCompany,
)

This should make pre-commit test green again...

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants