-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][MIG]helpdesk_mgmt: Add "close from portal" opt #516
base: 14.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review, LGTM
8a40bba
to
e25a098
Compare
* Ticket stage: Add a "close from portal" setting. * Portal form: Display ticket close buttons according to that setting. * Default stages: Add a "rejected" closed stage unavailable to portal. In the process: * Add portal close tests. * Protect against invalid target stage request in the controller.
* Ticket stage: Add a "close from portal" setting. * Portal form: Display ticket close buttons according to that setting. * Default stages: Add a "rejected" closed stage unavailable to portal. In the process: * Add portal close tests. * Protect against invalid target stage request in the controller.
* Ticket stage: Add a "close from portal" setting. * Portal form: Display ticket close buttons according to that setting. * Default stages: Add a "rejected" closed stage unavailable to portal. In the process: * Add portal close tests. * Protect against invalid target stage request in the controller.
* Ticket stage: Add a "close from portal" setting. * Portal form: Display ticket close buttons according to that setting. * Default stages: Add a "rejected" closed stage unavailable to portal. In the process: * Add portal close tests. * Protect against invalid target stage request in the controller.
* Ticket stage: Add a "close from portal" setting. * Portal form: Display ticket close buttons according to that setting. * Default stages: Add a "rejected" closed stage unavailable to portal. In the process: * Add portal close tests. * Protect against invalid target stage request in the controller.
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@renda-dev can you rebase please ? |
* Ticket stage: Add a "close from portal" setting. * Portal form: Display ticket close buttons according to that setting. * Default stages: Add a "rejected" closed stage unavailable to portal. In the process: * Add portal close tests. * Protect against invalid target stage request in the controller.
e25a098
to
9b19b7d
Compare
Done! 👍🏼 |
This PR has the |
ping @houzefa-abba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (code review only)
Greetings @OCA/helpdesk-maintainers, would it be possible to merge this PR based on existing reviews, I personally think that the feature is great :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review: LGTM
Hi @marcelsavegnago, is this PR merge-able? |
* Ticket stage: Add a "close from portal" setting. * Portal form: Display ticket close buttons according to that setting. * Default stages: Add a "rejected" closed stage unavailable to portal. In the process: * Add portal close tests. * Protect against invalid target stage request in the controller.
In the process:
Backport
15.0
=>14.0
of #383 as suggested by @pedrobaeza #466 (review)