Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG]helpdesk_mgmt: Add "close from portal" opt #516

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

renda-dev
Copy link

  • Ticket stage: Add a "close from portal" setting.
  • Portal form: Display ticket close buttons according to that setting.
  • Default stages: Add a "rejected" closed stage unavailable to portal.

In the process:

  • Add portal close tests.
  • Protect against invalid target stage request in the controller.

Backport 15.0 => 14.0 of #383 as suggested by @pedrobaeza #466 (review)

Copy link

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@renda-dev renda-dev force-pushed the 14.0-imp-helpdesk_mgmt branch from 8a40bba to e25a098 Compare January 9, 2024 07:59
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Jan 9, 2024
* Ticket stage: Add a "close from portal" setting.
* Portal form: Display ticket close buttons according to that setting.
* Default stages: Add a "rejected" closed stage unavailable to portal.

In the process:
* Add portal close tests.
* Protect against invalid target stage request in the controller.
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 8, 2024
* Ticket stage: Add a "close from portal" setting.
* Portal form: Display ticket close buttons according to that setting.
* Default stages: Add a "rejected" closed stage unavailable to portal.

In the process:
* Add portal close tests.
* Protect against invalid target stage request in the controller.
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 23, 2024
* Ticket stage: Add a "close from portal" setting.
* Portal form: Display ticket close buttons according to that setting.
* Default stages: Add a "rejected" closed stage unavailable to portal.

In the process:
* Add portal close tests.
* Protect against invalid target stage request in the controller.
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 24, 2024
* Ticket stage: Add a "close from portal" setting.
* Portal form: Display ticket close buttons according to that setting.
* Default stages: Add a "rejected" closed stage unavailable to portal.

In the process:
* Add portal close tests.
* Protect against invalid target stage request in the controller.
PicchiSeba pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 29, 2024
* Ticket stage: Add a "close from portal" setting.
* Portal form: Display ticket close buttons according to that setting.
* Default stages: Add a "rejected" closed stage unavailable to portal.

In the process:
* Add portal close tests.
* Protect against invalid target stage request in the controller.
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 12, 2024
@marcelsavegnago
Copy link
Member

@renda-dev can you rebase please ?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 26, 2024
* Ticket stage: Add a "close from portal" setting.
* Portal form: Display ticket close buttons according to that setting.
* Default stages: Add a "rejected" closed stage unavailable to portal.

In the process:
* Add portal close tests.
* Protect against invalid target stage request in the controller.
@renda-dev renda-dev force-pushed the 14.0-imp-helpdesk_mgmt branch from e25a098 to 9b19b7d Compare May 27, 2024 06:42
@renda-dev
Copy link
Author

Done! 👍🏼

@marcelsavegnago

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@marcelsavegnago
Copy link
Member

ping @houzefa-abba

Copy link
Member

@houzefa-abba houzefa-abba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review only)

@renda-dev
Copy link
Author

Greetings @OCA/helpdesk-maintainers, would it be possible to merge this PR based on existing reviews, I personally think that the feature is great :)

Copy link

@PicchiSeba PicchiSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: LGTM

@PicchiSeba
Copy link

Hi @marcelsavegnago, is this PR merge-able?

PicchiSeba pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Oct 14, 2024
* Ticket stage: Add a "close from portal" setting.
* Portal form: Display ticket close buttons according to that setting.
* Default stages: Add a "rejected" closed stage unavailable to portal.

In the process:
* Add portal close tests.
* Protect against invalid target stage request in the controller.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants