Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FW-PORT] helpdesk_mgmt: Simplify e-mail templates #467

Closed
wants to merge 3 commits into from
Closed

[14.0][FW-PORT] helpdesk_mgmt: Simplify e-mail templates #467

wants to merge 3 commits into from

Conversation

ypapouin
Copy link
Contributor

This PR has been split from #448

  • E-mail templates are simplified, they now all use the mail.mail_notification_light layout to have a consistent design.
  • Send a notification to the partner each time the ticket stage changes.

pedrobaeza
pedrobaeza requested changes May 14, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also mixing several things. All related to mail templates, but too much extreme changes IMO.

helpdesk_mgmt/data/helpdesk_data.xml Outdated Show resolved Hide resolved
helpdesk_mgmt/data/helpdesk_data.xml Outdated Show resolved Hide resolved
@ypapouin ypapouin force-pushed the 14.0-fw-port-12.0-email-templates branch from faeeb5c to 6150f6f Compare May 16, 2023 08:05
@ypapouin
Copy link
Contributor Author

The display_name is now used for all templates body.
I also edited the doc to explain the stage's email template.

@pedrobaeza pedrobaeza added this to the 14.0 milestone May 16, 2023
pedrobaeza
pedrobaeza reviewed May 16, 2023
View reviewed changes
helpdesk_mgmt/models/helpdesk_ticket.py Outdated Show resolved Hide resolved
helpdesk_mgmt/models/helpdesk_ticket.py Outdated Show resolved Hide resolved
helpdesk_mgmt/models/helpdesk_ticket.py Show resolved Hide resolved
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 17, 2023
@ypapouin ypapouin force-pushed the 14.0-fw-port-12.0-email-templates branch from 19f6fa0 to a836c25 Compare October 11, 2023 13:55
renda-dev
renda-dev approved these changes Oct 23, 2023
View reviewed changes
Copy link

@renda-dev renda-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of quick and really small changes could be made but the code LGTM overall.

helpdesk_mgmt/models/helpdesk_ticket.py Outdated Show resolved Hide resolved
helpdesk_mgmt/models/helpdesk_ticket.py Outdated Show resolved Hide resolved
@ypapouin ypapouin force-pushed the 14.0-fw-port-12.0-email-templates branch from a836c25 to ef33c7c Compare October 24, 2023 07:24
eLBati and others added 3 commits October 24, 2023 09:27
@eLBati @ypapouin
[IMP] helpdesk_mgmt: Use email layout to simplify all templates
c7a5342 
- Avoid email_cc (error "message without recipients")
- Use coherent partner/user reference
- Access button from e-mail notifications

Semi-forward port of 98e5ef7

Please note that the commit a5041c2 (An e-mail is sent to the ticket after each create/edit) has not been forward ported because the assignment notify is done internally by odoo in `_message_auto_subscribe_followers` from `mail.thread`
@eLBati @ypapouin
[IMP] helpdesk_mgmt: Test access added
f977858 
Forward port of dfbc369
@ypapouin
[IMP] helpdesk_mgmt: Doc update
1625ab7
@ypapouin ypapouin force-pushed the 14.0-fw-port-12.0-email-templates branch from ef33c7c to 1625ab7 Compare October 24, 2023 07:28
@github-actions github-actions bot closed this Nov 26, 2023
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Jan 9, 2024
@eLBati @renda-dev
[PR OCA#467] [IMP] helpdesk_mgmt: Use email layout to simplify all te…
03ede46 
…mplates

- Avoid email_cc (error "message without recipients")
- Use coherent partner/user reference
- Access button from e-mail notifications

Semi-forward port of 98e5ef7

Please note that the commit a5041c2 (An e-mail is sent to the ticket after each create/edit) has not been forward ported because the assignment notify is done internally by odoo in `_message_auto_subscribe_followers` from `mail.thread`
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Jan 9, 2024
@eLBati @renda-dev
[PR OCA#467] [IMP] helpdesk_mgmt: Test access added
f8fee72 
Forward port of dfbc369
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Jan 9, 2024
@ypapouin @renda-dev
[PR OCA#467] [IMP] helpdesk_mgmt: Doc update
95095a1
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 8, 2024
@eLBati @renda-dev
[PR OCA#467] [IMP] helpdesk_mgmt: Use email layout to simplify all te…
970a34c 
…mplates

- Avoid email_cc (error "message without recipients")
- Use coherent partner/user reference
- Access button from e-mail notifications

Semi-forward port of 98e5ef7

Please note that the commit a5041c2 (An e-mail is sent to the ticket after each create/edit) has not been forward ported because the assignment notify is done internally by odoo in `_message_auto_subscribe_followers` from `mail.thread`
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 8, 2024
@eLBati @renda-dev
[PR OCA#467] [IMP] helpdesk_mgmt: Test access added
ec4542d 
Forward port of dfbc369
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 8, 2024
@ypapouin @renda-dev
[PR OCA#467] [IMP] helpdesk_mgmt: Doc update
f7b27dc
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 23, 2024
@eLBati @renda-dev
[PR OCA#467] [IMP] helpdesk_mgmt: Use email layout to simplify all te…
7e936a9 
…mplates

- Avoid email_cc (error "message without recipients")
- Use coherent partner/user reference
- Access button from e-mail notifications

Semi-forward port of 98e5ef7

Please note that the commit a5041c2 (An e-mail is sent to the ticket after each create/edit) has not been forward ported because the assignment notify is done internally by odoo in `_message_auto_subscribe_followers` from `mail.thread`
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 23, 2024
@eLBati @renda-dev
[PR OCA#467] [IMP] helpdesk_mgmt: Test access added
fd84e90 
Forward port of dfbc369
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 23, 2024
@ypapouin @renda-dev
[PR OCA#467] [IMP] helpdesk_mgmt: Doc update
699475d
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 24, 2024
@eLBati @renda-dev
[PR OCA#467] [IMP] helpdesk_mgmt: Use email layout to simplify all te…
fd029a1 
…mplates

- Avoid email_cc (error "message without recipients")
- Use coherent partner/user reference
- Access button from e-mail notifications

Semi-forward port of 98e5ef7

Please note that the commit a5041c2 (An e-mail is sent to the ticket after each create/edit) has not been forward ported because the assignment notify is done internally by odoo in `_message_auto_subscribe_followers` from `mail.thread`
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 24, 2024
@eLBati @renda-dev
[PR OCA#467] [IMP] helpdesk_mgmt: Test access added
6609f50 
Forward port of dfbc369
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 24, 2024
@ypapouin @renda-dev
[PR OCA#467] [IMP] helpdesk_mgmt: Doc update
000eaa2
PicchiSeba pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 29, 2024
@eLBati @PicchiSeba
[PR OCA#467] [IMP] helpdesk_mgmt: Use email layout to simplify all te…
245ac17 
…mplates

- Avoid email_cc (error "message without recipients")
- Use coherent partner/user reference
- Access button from e-mail notifications

Semi-forward port of 98e5ef7

Please note that the commit a5041c2 (An e-mail is sent to the ticket after each create/edit) has not been forward ported because the assignment notify is done internally by odoo in `_message_auto_subscribe_followers` from `mail.thread`
PicchiSeba pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 29, 2024
@eLBati @PicchiSeba
[PR OCA#467] [IMP] helpdesk_mgmt: Test access added
59907fe 
Forward port of dfbc369
PicchiSeba pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 29, 2024
@ypapouin @PicchiSeba
[PR OCA#467] [IMP] helpdesk_mgmt: Doc update
e8eeb1b
PicchiSeba pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Oct 14, 2024
@eLBati @PicchiSeba
[PR OCA#467] [IMP] helpdesk_mgmt: Use email layout to simplify all te…
ec58588 
…mplates

- Avoid email_cc (error "message without recipients")
- Use coherent partner/user reference
- Access button from e-mail notifications

Semi-forward port of 98e5ef7

Please note that the commit a5041c2 (An e-mail is sent to the ticket after each create/edit) has not been forward ported because the assignment notify is done internally by odoo in `_message_auto_subscribe_followers` from `mail.thread`
PicchiSeba pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Oct 14, 2024
@eLBati @PicchiSeba
[PR OCA#467] [IMP] helpdesk_mgmt: Test access added
741e746 
Forward port of dfbc369
PicchiSeba pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Oct 14, 2024
@ypapouin @PicchiSeba
[PR OCA#467] [IMP] helpdesk_mgmt: Doc update
99b3b92
@PicchiSeba PicchiSeba mentioned this pull request Oct 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PicchiSeba PicchiSeba PicchiSeba left review comments

@pedrobaeza pedrobaeza pedrobaeza requested changes

@renda-dev renda-dev renda-dev approved these changes

Assignees
No one assigned
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ypapouin @pedrobaeza @PicchiSeba @renda-dev @eLBati