Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][PORT] 826 from 14.0 #848

Merged
merged 1 commit into from
Feb 3, 2024
Merged

[16.0][PORT] 826 from 14.0 #848

merged 1 commit into from
Feb 3, 2024

Conversation

bosd
Copy link
Contributor

@bosd bosd commented Nov 3, 2023

Port #826 from 14.0 to 16.0.

@OCA-git-bot
Copy link
Contributor

Hi @alexis-via,
some modules you are maintaining are being modified, check this out!

Dranyel-Bosd
Dranyel-Bosd approved these changes Nov 16, 2023
View reviewed changes
Copy link

@Dranyel-Bosd Dranyel-Bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally review

bofiltd
bofiltd approved these changes Nov 27, 2023
View reviewed changes
Copy link

@bofiltd bofiltd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@bosd
Copy link
Contributor Author

bosd commented Dec 28, 2023

@simahawk Can you please merge this one?? 🙏

@bosd
Copy link
Contributor Author

bosd commented Feb 3, 2024

@alexis-via Can you please merge 🙏

@alexis-via
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-848-by-alexis-via-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8dcdbf5 into OCA:16.0 Feb 3, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f118c44. Thanks a lot for contributing to OCA. ❤️

@bosd bosd deleted the 16.0-826-port branch February 3, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dranyel-Bosd Dranyel-Bosd Dranyel-Bosd approved these changes

@bofiltd bofiltd bofiltd approved these changes

@alexis-via alexis-via alexis-via approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bosd @OCA-git-bot @alexis-via @bofiltd @Dranyel-Bosd