Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] base_edifact: Support more EDIFACT format #835

Merged
merged 11 commits into from
Oct 26, 2023
Merged

[16.0][IMP] base_edifact: Support more EDIFACT format #835

merged 11 commits into from
Oct 26, 2023

Conversation

thienvh332
Copy link
Contributor

@thienvh332 thienvh332 commented Oct 20, 2023 •
edited
Loading

  • Support "latin-1" format
  • Get product fallback on SA if no EAN is given
  • Fallback if address information is missing
  • Add get price with Price qualifier is AAB
  • support getting product description from the IMD segment

@OCA-git-bot
Copy link
Contributor

Hi @rmorant,
some modules you are maintaining are being modified, check this out!

@thienvh332 thienvh332 marked this pull request as draft October 20, 2023 08:12
@thienvh332 thienvh332 force-pushed the 16.0-imp-base_edifact branch from 0263c69 to c27655a Compare October 23, 2023 09:05
simahawk
simahawk reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still draft?

base_edifact/models/edifact.py Outdated Show resolved Hide resolved
@thienvh332 thienvh332 force-pushed the 16.0-imp-base_edifact branch from 70070e3 to 5926ca2 Compare October 24, 2023 03:58
@thienvh332 thienvh332 force-pushed the 16.0-imp-base_edifact branch from 5926ca2 to 2162cb9 Compare October 24, 2023 10:41
@thienvh332 thienvh332 marked this pull request as ready for review October 25, 2023 08:43
simahawk
simahawk approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@simahawk
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-835-by-simahawk-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8a02f36 into OCA:16.0 Oct 26, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0d3368a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thienvh332 @OCA-git-bot @simahawk