Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account_payment_promissory_note occludes due date of invoice_date_due #731

Open
risto42 opened this issue May 29, 2024 · 3 comments
Open
Labels
bug stale PR/Issue without recent activity, it'll be soon closed automatically.

Comments

@risto42
Copy link

risto42 commented May 29, 2024

At least in 16.0, the following warning comes up numerous times:

WARNING <db> odoo.addons.base.models.ir_model: Two fields (invoice_date_due, date_due) of account.payment() have the same label: Due Date. [Modules: None and account_payment_promissory_note] 

robably should let the msgid be "Promissory Note Due Date" with the msgstr as "Due Date" if necessary to avoid stepping on toes of other modules, while keeping the noise out of the log file.

@risto42 risto42 added the bug label May 29, 2024
@pedrobaeza
Copy link
Member

Please propose a PR changing the string.

@risto42
Copy link
Author

risto42 commented May 30, 2024

Well, I'm not actually using this module as of yet, it's just muddying the waters with the warnings.

After looking at it, it appears that the module stopped in the middle of a migration to a mixin where two fields were doubled as well. So I put the fields into the mixin, kept the default label name and updated the translations.

Attached is the quick patch for someone who is active on this module to decide whether indeed it's worthwhile even to keep the mixin... as I don't see any readily available design rationale justifying it.
AP-731.zip

Copy link

github-actions bot commented Dec 1, 2024

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

No branches or pull requests

2 participants