Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0] [MIG] account_fiscal_position_autodetect_optional_vies: Migration to 15.0 #374

Conversation

angelgarciadelachica
Copy link

Standard migration

victoralmau and others added 10 commits September 27, 2023 17:04
…dds vat VIES validation to fiscal positions.

TT30631
… type in test partner

After OCA/OCB@4518968#diff-1ef5fe83935572c9b9b9e6eec69a44551023f3b92fe38bed4f765a24e16694b4 and OCA/OCB@198a4dd the associated partner needs to be of type `company` for the vies check to work.

@Tecnativa
…n contacts

Steps to reproduce the problem:

- Create a partner with a proper VIES VAT.
- Create a children for that partner.
- Create a fiscal position with "Vat was VIES validated" and
  "Auto-apply" marks checked.
- Use the children partner in an invoice.

Current behavior:

The fiscal position is not selected.

Expected behavior:

The fiscal position is selected.

TT38107
@angelgarciadelachica
Copy link
Author

@Jesarregui
Copy link

LGTM

Copy link
Contributor

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Jesarregui Jesarregui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HaraldPanten
Copy link
Contributor

@pedrobaeza I'll merge this one if it's OK for you. Your team is the original author

@pedrobaeza
Copy link
Member

Go on!

@HaraldPanten
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-374-by-HaraldPanten-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit da8959b into OCA:15.0 Sep 28, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 96690e6. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 15.0-mig-account_fiscal_position_autodetect_optional_vies branch September 28, 2023 10:13
@HaraldPanten
Copy link
Contributor

/ocabot migration account_fiscal_position_autodetect_optional_vies

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Sep 28, 2023
@OCA-git-bot
Copy link
Contributor

There's no issue in this repo with the title 'Migration to version 15.0' and the milestone 15.0, so not possible to add the comment.

@HaraldPanten HaraldPanten mentioned this pull request Sep 28, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants