Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question]Delete unistalled module during the pre-migration ? #4673

Open
flotho opened this issue Nov 22, 2024 · 3 comments
Open

[Question]Delete unistalled module during the pre-migration ? #4673

flotho opened this issue Nov 22, 2024 · 3 comments

Comments

@flotho
Copy link
Member

flotho commented Nov 22, 2024

Is your feature request related to a problem?

During an update from 14 to 15 I faced a duplicate module name issue on module that are not installed.

Describe the solution you'd like
I'm wondering if it could be a great idea to delete all modules that are not installed before executing the apriori.py operations

@pedrobaeza
Copy link
Member

We don't do it because there can be some module that need to be detected or to be marked as "to install", so this may prevent these operations.

@legalsylvain
Copy link
Contributor

@flotho could you elaborate ? The modules conflicting ? Etc. Thanks !

@flotho
Copy link
Member Author

flotho commented Nov 23, 2024

First, thanks a lot for reacting and explaining.
Totally undestood what i missed @pedrobaeza .
@legalsylvain I proposed this because of this one #3556
This PR don't solve the issue I've faced. I have both l10n_eu_oss and l10n_eu_service present in my database and if failed because of a duplicate. As both module were not installed, I deleted all the uninstalled modules and then it wok like a charm.
Maybe we could combine 2 behaviours :

  • First delete all unistalled modules
  • Then rescan all the available modules for the current version
  • let the process run smoothly

You're feedback will be welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants