Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass token info into fidget settings for default token spaces #530

Open
willyogo opened this issue Dec 17, 2024 · 3 comments
Open

Pass token info into fidget settings for default token spaces #530

willyogo opened this issue Dec 17, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@willyogo
Copy link
Collaborator

willyogo commented Dec 17, 2024

As a user, I want the fidgets on a default token space to be populated with the info for that token.

AC:

  1. Feed fidget is filtered to the keyword for the token symbol (can be queried directly from the contract, and/or from the parent cast for Clanker tokens) (requires Add 'keyword' to the conditional settings for Feed fidget #531)
  2. For Clanker tokens, the pinned cast fidget displays the parent cast that tagged Clanker to deploy the token (TBD what we'll put here instead for non-clanker tokens)
  3. Links fidget is populated with links to the the token on Basescan, Dexscreener, and (if Clanker token), clanker.world
  4. Token score fidget/iframe is populated with the score for that token (TBD)
  5. Price fidget/iframe is populated with the token's address + chain (base for now)
  6. Swap fidget is populated with the token's address as defaultBuyToken and chain as buy chain (base for now), and ETH on base as the default sell token & chain
@willyogo willyogo added the enhancement New feature or request label Dec 17, 2024
@willyogo willyogo added this to the Token Spaces milestone Dec 17, 2024
@hiporox
Copy link
Collaborator

hiporox commented Dec 17, 2024

For non-clanker tokens, how do we enable users to claim ownership of the space? With Clanker we can use the account that casted the deploying cast, but for other tokens there is not the same clear route

@willyogo
Copy link
Collaborator Author

since not all ERC20 tokens have the 'owner' field, we aligned on this approach:

Grab ABI from contract and use the first available:

  1. fid
  2. owner
  3. deployer

If none of these are on contract, use the address of the contract creator

@willyogo
Copy link
Collaborator Author

hiporox can set up the initial structure for this with passing the cast hash & fid from clanker contract into pinned cast fidget.

@sktbrd can pass in props for other fidgets once default token space config is finalized

@willyogo willyogo moved this to In Progress in nounspace v0.1 Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

3 participants