Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match warpcast's pfp cropping #420

Open
willyogo opened this issue Sep 11, 2024 · 3 comments
Open

Match warpcast's pfp cropping #420

willyogo opened this issue Sep 11, 2024 · 3 comments
Assignees
Milestone

Comments

@willyogo
Copy link
Collaborator

Currently on nounspace, some pfp's are cropped very differently than they are on warpcast, causing them to look weird and potentially turning off some warpcast users that give nounspace a try.

Example:
image
image
image

Note that on some profiles, there's no noticeable difference.
image
image

AC:

  1. PFPs on nounspace look the same as PFPs on warpcast
@willyogo
Copy link
Collaborator Author

Plz also fix in the search modal
image

@sktbrd
Copy link
Collaborator

sktbrd commented Sep 11, 2024

issue 420 is miiiine

@willyogo willyogo moved this to Todo in nounspace v0.1 Sep 13, 2024
@willyogo willyogo added this to the Polish milestone Sep 13, 2024
@r4topunk
Copy link
Contributor

Hey everyone, I noticed that Nounspace is rendering an image with a different aspect ratio compared to Warpcast.

Here’s the image from Nounspace:
https://imagedelivery.net/BXluQx4ige9GuW0Ia56BHw/ba092c8b-ba7c-4891-c124-f670b70b6800/rectcrop3

And this is the one from Warpcast:
https://wrpcd.net/cdn-cgi/imagedelivery/BXluQx4ige9GuW0Ia56BHw/ba092c8b-ba7c-4891-c124-f670b70b6800/anim=false,fit=contain,f=auto,w=336

It seems like both are using a CDN with different image cropping methods.

@sktbrd sktbrd assigned j-paterson and unassigned sktbrd Oct 29, 2024
@willyogo willyogo removed the status in nounspace v0.1 Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

4 participants