Skip to content

feat!: Version 0.19.2 #278

feat!: Version 0.19.2

feat!: Version 0.19.2 #278

Triggered via pull request March 22, 2024 12:53
@64knl64knl
opened #226
develop
Status Failure
Total duration 1m 48s
Artifacts

insights.yml

on: pull_request
PHP Insights checks
1m 37s
PHP Insights checks
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 2 warnings
PHP Insights checks: src/Auth/Notifications/VerifyEmail.php#L19
* [Forbidden public property] Do not use public properties. Use method access instead. * [Property type hint] Property \NotFound\Framework\Auth\Notifications\VerifyEmail::$createUrlCallback does not have native type hint for its value but it should be possible to add it based on @var annotation "\Closure|null".
PHP Insights checks: src/Auth/Notifications/VerifyEmail.php#L26
* [Forbidden public property] Do not use public properties. Use method access instead. * [Property type hint] Property \NotFound\Framework\Auth\Notifications\VerifyEmail::$toMailCallback does not have native type hint for its value but it should be possible to add it based on @var annotation "\Closure|null".
PHP Insights checks: src/Auth/Notifications/VerifyEmail.php#L1
* [Declare strict types] Missing declare(strict_types=1). * [New with braces] @@ -63,3 +63,3 @@ { - return (new MailMessage) + return (new MailMessage()) ->subject(Lang::get('Verify Email Address')) * [Normal classes are forbidden. Classes must be final or abstract] * [Ordered class elements] @@ -56,2 +56,24 @@ /** + * Set a callback that should be used when creating the email verification URL. + * + * @param \Closure $callback + * @return void + */ + public static function createUrlUsing($callback) + { + static::$createUrlCallback = $callback; + } + + /** + * Set a callback that should be used when building the notification mail message. + * + * @param \Closure $callback + * @return void + */ + public static function toMailUsing($callback) + { + static::$toMailCallback = $callback; + } + + /** * Get the verify email notification mail message for the given URL. @@ -91,24 +113,2 @@ ); - } - - /** - * Set a callback that should be used when creating the email verification URL. - * - * @param \Closure $callback - * @return void - */ - public static function createUrlUsing($callback) - { - static::$createUrlCallback = $callback; - } - - /** - * Set a callback that should be used when building the notification mail message. - * - * @param \Closure $callback - * @return void - */ - public static function toMailUsing($callback) - { - static::$toMailCallback = $callback; }
PHP Insights checks: src/Auth/Notifications/VerifyEmail.php#L31
* [Disallow mixed type hint] Usage of "mixed" type hint is disallowed.
PHP Insights checks: src/Auth/Notifications/VerifyEmail.php#L42
* [Disallow mixed type hint] Usage of "mixed" type hint is disallowed.
PHP Insights checks: src/Auth/Notifications/VerifyEmail.php#L74
* [Disallow mixed type hint] Usage of "mixed" type hint is disallowed.
PHP Insights checks: src/Auth/Notifications/VerifyEmail.php#L34
* [Parameter type hint] Method \NotFound\Framework\Auth\Notifications\VerifyEmail::via() does not have native type hint for its parameter $notifiable but it should be possible to add it based on @param annotation "mixed". * [Return type hint] Method \NotFound\Framework\Auth\Notifications\VerifyEmail::via() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "array|string". * [Unused parameter] Unused parameter $notifiable.
PHP Insights checks: src/Auth/Notifications/VerifyEmail.php#L45
* [Parameter type hint] Method \NotFound\Framework\Auth\Notifications\VerifyEmail::toMail() does not have native type hint for its parameter $notifiable but it should be possible to add it based on @param annotation "mixed". * [Return type hint] Method \NotFound\Framework\Auth\Notifications\VerifyEmail::toMail() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Notifications\Messages\MailMessage".
PHP Insights checks: src/Auth/Notifications/VerifyEmail.php#L62
* [Parameter type hint] Method \NotFound\Framework\Auth\Notifications\VerifyEmail::buildMailMessage() does not have native type hint for its parameter $url but it should be possible to add it based on @param annotation "string". * [Return type hint] Method \NotFound\Framework\Auth\Notifications\VerifyEmail::buildMailMessage() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Notifications\Messages\MailMessage".
PHP Insights checks: src/Auth/Notifications/VerifyEmail.php#L77
* [Parameter type hint] Method \NotFound\Framework\Auth\Notifications\VerifyEmail::verificationUrl() does not have native type hint for its parameter $notifiable but it should be possible to add it based on @param annotation "mixed". * [Return type hint] Method \NotFound\Framework\Auth\Notifications\VerifyEmail::verificationUrl() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "string".
PHP Insights checks
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
PHP Insights checks
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/