ADBMS Integration #138

Sabramz · 2024-11-18T03:06:56Z

Changes

Low level drivers and some integration.

Test Cases

test bench

To Do

Voltage reading function is scalable
Therm reading function is scalable
Functions for reading every register
Voltage reading can be configured to be s, c, filtered, and avg
Function for setting GPIOs as outputs
New configuration function for new ICs

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

All commits are tagged with the ticket number
No merge conflicts
All checks passing
Remove any non-applicable sections of this template
Assign the PR to yourself
Request reviewers & ping on Slack
PR is linked to the ticket (fill in the closes line below)

Closes #133 (issue #)

…ed on pulling voltages

jr1221 · 2024-11-22T00:13:01Z

Core/Src/main.c

+  int DataIdx;
+
+  for (DataIdx = 0; DataIdx < len; DataIdx++) {
+    __io_putchar( *ptr++ );


messed up diff this stuff was changed on main??

I changed this cuz printing was broken and i think it was cuz of the usart dma changes.

hmm did u use \r? Also make sure to use ner serial or else it wont work.

jr1221 · 2024-11-22T00:16:03Z

Core/Src/segment.c

 {
-	LTC6804_wrcfg(ltc68041, NUM_CHIPS, local_config);
+	adBmsCsLow();
+	adBmsCsHigh();


can you add comment where the original source waits for a time?

Core/Src/segment.c

jr1221 · 2024-11-22T00:17:08Z

Core/Src/segment.c

+
+	// Init config B
+	chip->tx_cfgb.vov = SetOverVoltageThreshold(4.2);
+	chip->tx_cfgb.vuv = SetUnderVoltageThreshold(3.0);


can u add a comment that this prob doesnt matter?

The threshold matters. If its set wrong the ic will tell us we are faulting.

But we don't use the over/under fault stuff right?

jr1221

A bunch of random stuff idk you prob know all of this anyway as this is WIP.

Only thing actually wierd is the whole wakeup IC stuff and how we now have a bunch of different types of wakeup functions all seeming to do similar stuff.

jr1221 · 2024-11-22T03:15:50Z

Core/Inc/bmsConfig.h

-#define NUM_CELLS_PER_CHIP  10
+#define NUM_SEGMENTS	    1
+#define NUM_CHIPS	    1 //NUM_SEGMENTS * 2
+#define NUM_CELLS_PER_CHIP  16
 #define NUM_THERMS_PER_CHIP 32
 #define NUM_RELEVANT_THERMS 3


what does this mean?

Its the number of therms that we actually wanted to read on a segment. I think we'll be getting rid of this but i think its outside the scope of this.

jr1221 · 2024-11-22T03:17:17Z

Makefile

+Drivers/adbms/lib/src/adBms6830GenericType.c \
+Drivers/adbms/lib/src/adBms6830ParseCreate.c \
+Drivers/adbms/program/src/serialPrintResult.c \
+Drivers/adbms/program/src/mcuWrapper.c \


should we be using this file? Versus just defining our own.

It has our edits in it (just the ones we used to get shep working at first)

jr1221 · 2024-11-22T03:17:59Z

Core/Src/segment.c

+#define TOTAL_IC 1
+cell_asic IC[TOTAL_IC];
+
+RD REDUNDANT_MEASUREMENT = RD_OFF;


we do want redundant in final rev

Sure we can do that later. I want a full spec from BMS team on exactly what the configs should be and how they want the BMS to work

jr1221 · 2024-11-22T03:18:48Z

Core/Src/segment.c

+cell_asic IC[TOTAL_IC];
+
+RD REDUNDANT_MEASUREMENT = RD_OFF;
+CH AUX_CH_TO_CONVERT = AUX_ALL;


we need to setup which AUX channel is read by which multiplexer. The mtg notes I think say the main multiplexer reads internal register and the AUX is dedicated to the GPIOs.

These variables won't make it into the final draft. this was copied over from adbms source.

They'll be gone once this code is tested.

jr1221 · 2024-11-22T03:19:03Z

Core/Src/segment.c

+
+RD REDUNDANT_MEASUREMENT = RD_OFF;
+CH AUX_CH_TO_CONVERT = AUX_ALL;
+CONT CONTINUOUS_MEASUREMENT = SINGLE;


we def want continuous measurement?

this variable is not used

Core/Src/segment.c

jr1221 · 2024-11-22T03:24:47Z

Core/Src/segment.c

+void get_c_adc_voltages(cell_asic *chip)
+{
+	wake_and_write_configs(chip);
+	adbms_wake();


why wake so many times?

thats just what worked in testing

jr1221 · 2024-11-22T03:26:21Z

Core/Src/segment.c

@@ -125,9 +309,65 @@ void select_therm(uint8_t therm)
 			 1); // 0-15, will change multiplexer to select thermistor
 	}
 	serialize_i2c_msg(i2c_write_data, comm_reg_data);


shouldnt we yeet all therm selection multiplexing?

jr1221 · 2024-11-22T03:27:32Z

Core/Src/segment.c

+		printVoltages(TOTAL_IC, &IC[0], F_volt);
+	} */
+
+	if (MEASURE_S_VOLTAGE == ENABLED) {


eventually we should just do redundant reads and not read S seperately

jr1221 · 2024-11-22T03:29:02Z

Core/Src/main.c

+  int DataIdx;
+
+  for (DataIdx = 0; DataIdx < len; DataIdx++) {
+    __io_putchar( *ptr++ );


hmm did u use \r? Also make sure to use ner serial or else it wont work.

…datastructure

jr1221

more code hip hip hooray. really its impossible to figure out what is good and bad practice until the high level code gels better (we remove the years of therm and algo disable crap).

jr1221 · 2024-12-27T00:37:46Z

Core/Src/segment.c

-	}
+	// TODO: Its kind of silly to just copy voltages like this. We should consolidate
+	// chip data and chips later, or design analyzer to read voltages from chips rather
+	// than chipdata


agree with both of the above TODOs.

jr1221 · 2024-12-27T00:44:34Z

Core/Src/segment.c

+ */
+void read_aux2_registers(cell_asic chips[NUM_CHIPS])
+{
+	write_config_regs(chips);


for all read_* commands. Why do we write to registers each time? Feels like we dont need to?

jr1221 · 2024-12-27T00:51:42Z

Core/Src/analyzer.c

+	for (int chip = 0; chip < NUM_CHIPS; chip++) {
+		for (int i = 0; i < NUM_CELLS_PER_CHIP; i++) {
+			real_total_volt +=
+				getVoltage(bmsdata->chip_data[chip].voltage[i]);


see my questions in slack about chip_data. We shouldnt call getVoltage on a struct field outside of adbms, that feels wierd and takes their specific register format to the rest of the code. Imo we should either remove chipdata_t and call stuff on cell_asic or store the cell_asic stuff as floats post-conversion.

Sabramz added 5 commits November 17, 2024 19:19

133 adbms submodule

60650d1

133 more copying

89b9d97

133 it works

004e83d

133 debugging

fe7b35e

133 working prints

331f9dd

Sabramz marked this pull request as draft November 18, 2024 03:07

Sabramz requested review from dyldonahue and jr1221 November 21, 2024 23:07

Sabramz self-assigned this Nov 21, 2024

adbms functions for config registers, get rid of some LTC code, start…

a7bff61

…ed on pulling voltages

jr1221 reviewed Nov 22, 2024

View reviewed changes

Core/Src/segment.c Show resolved Hide resolved

jr1221 reviewed Nov 22, 2024

View reviewed changes

Core/Src/segment.c Show resolved Hide resolved

jr1221 reviewed Nov 22, 2024

View reviewed changes

Sabramz added 5 commits November 26, 2024 19:34

adbms reworking code for daisy chaining

ccff5e0

adbms wrapper written **untested**

d1b4701

adbms cleaning up old functions

c671679

adbms balancing config changes

f0a2a60

adbms add chips to acc_data_t and make functions compatible with new …

e611107

…datastructure

Sabramz marked this pull request as ready for review December 25, 2024 23:44

Sabramz requested review from jr1221 and removed request for dyldonahue December 25, 2024 23:46

Sabramz added 2 commits December 25, 2024 19:06

adbms changing GPIO modes and integrating balancing functions with adbms

6791c57

adbms cleaning up balancing and removing LTC driver from make file

93379f0

jr1221 reviewed Dec 27, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ADBMS Integration #138

ADBMS Integration #138

Sabramz commented Nov 18, 2024 •

edited

Loading

jr1221 Nov 22, 2024

Sabramz Nov 22, 2024

jr1221 Nov 22, 2024

jr1221 Nov 22, 2024

jr1221 Nov 22, 2024

Sabramz Dec 8, 2024

jr1221 Dec 25, 2024

jr1221 left a comment

jr1221 Nov 22, 2024

Sabramz Dec 8, 2024

jr1221 Nov 22, 2024

Sabramz Dec 8, 2024

jr1221 Nov 22, 2024

Sabramz Dec 8, 2024

jr1221 Nov 22, 2024

Sabramz Dec 8, 2024

Sabramz Dec 8, 2024

jr1221 Nov 22, 2024

Sabramz Dec 8, 2024

jr1221 Nov 22, 2024

Sabramz Dec 8, 2024

jr1221 Nov 22, 2024

jr1221 Nov 22, 2024

jr1221 Nov 22, 2024

jr1221 left a comment

jr1221 Dec 27, 2024

jr1221 Dec 27, 2024

jr1221 Dec 27, 2024

ADBMS Integration #138

Are you sure you want to change the base?

ADBMS Integration #138

Conversation

Sabramz commented Nov 18, 2024 • edited Loading

Changes

Test Cases

To Do

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jr1221 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jr1221 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Sabramz commented Nov 18, 2024 •

edited

Loading