Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring - Create Subheader Component and replace all subheaders with this component #54

Closed
5 tasks
Peyton-McKee opened this issue Jan 25, 2024 · 0 comments · Fixed by #61
Closed
5 tasks

Refactoring - Create Subheader Component and replace all subheaders with this component #54

Peyton-McKee opened this issue Jan 25, 2024 · 0 comments · Fixed by #61
Assignees
@tGiech22
Labels
good first issue Good for newcomers medium A more complex task view Development Focusing on a View

Comments

@Peyton-McKee
Copy link
Collaborator

Peyton-McKee commented Jan 25, 2024 •
edited
Loading

Description

We want a component that displays our subheader text, this is so that if we change how we want our subheaders to look we only have to change one component instead of changing it everywhere.

Acceptance Criteria

  • Takes in text property
  • Looks like mock
  • Font size 24
  • color BFBFBF
  • Replace all our current subheader text with this component

Proposed Solution

^

Mocks

Screenshot 2024-01-24 at 10 20 54 PM
@Peyton-McKee Peyton-McKee added good first issue Good for newcomers medium A more complex task view Development Focusing on a View labels Jan 25, 2024
tGiech22 added a commit that referenced this issue Jan 26, 2024
@tGiech22
#54-Subheader-Component creation
a554623
tGiech22 added a commit that referenced this issue Jan 26, 2024
@tGiech22
#54-Subheader-Component saving changes and cleaning branch
d7816ac
@tGiech22 tGiech22 mentioned this issue Jan 26, 2024
Merged
10 tasks
tGiech22 added a commit that referenced this issue Jan 26, 2024
@tGiech22
#54-Subheader-Component
d73a1e5
@Peyton-McKee Peyton-McKee linked a pull request Jan 29, 2024 that will close this issue
#54-Subheader component #61
Merged
10 tasks
tGiech22 added a commit that referenced this issue Jan 30, 2024
@tGiech22
#54 changed color of ValueText
69789e3
tGiech22 added a commit that referenced this issue Jan 30, 2024
@tGiech22
#54 reverting ValueText back to original form
2a62138
tGiech22 added a commit that referenced this issue Jan 30, 2024
@tGiech22
#54 reverting change to CMakeLists
92e7db2
tGiech22 added a commit that referenced this issue Jan 31, 2024
@tGiech22
#54 changing Label Text color
0a78fa4
tGiech22 added a commit that referenced this issue Jan 31, 2024
@tGiech22
Revert "#54 reverting change to CMakeLists"
9d1412b 
This reverts commit 92e7db2.
tGiech22 added a commit that referenced this issue Jan 31, 2024
@tGiech22
Revert "#54 reverting ValueText back to original form"
45d3e0a 
This reverts commit 2a62138.
tGiech22 added a commit that referenced this issue Jan 31, 2024
@tGiech22
Revert "#54 changed color of ValueText"
8266fbc 
This reverts commit 69789e3.
tGiech22 added a commit that referenced this issue Jan 31, 2024
@tGiech22
Revert "#54-Subheader-Component"
c434e2b 
This reverts commit d73a1e5.
tGiech22 added a commit that referenced this issue Jan 31, 2024
@tGiech22
Revert "#54-Subheader-Component saving changes and cleaning branch"
14ba575 
This reverts commit d7816ac.
tGiech22 added a commit that referenced this issue Jan 31, 2024
@tGiech22
Revert "#54-Subheader-Component creation"
f292267 
This reverts commit a554623.
tGiech22 added a commit that referenced this issue Jan 31, 2024
@tGiech22
#54 changing color of LabelText
d752f0e
tGiech22 added a commit that referenced this issue Feb 1, 2024
@tGiech22
#54 forgot the hashtags for the color
dcd55a9
Peyton-McKee added a commit that referenced this issue Feb 2, 2024
@Peyton-McKee
Merge pull request #61 from Northeastern-Electric-Racing/Subheader-Co…
693dc24 
…mponent

#54-Subheader component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tGiech22 tGiech22

Labels
good first issue Good for newcomers medium A more complex task view Development Focusing on a View
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#54-Subheader component Northeastern-Electric-Racing/Nero-2.0
2 participants
@tGiech22 @Peyton-McKee