Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RULES: Pedal tuning & transfer function refactor 24A #247

Open
jr1221 opened this issue Dec 20, 2024 · 0 comments
Open

RULES: Pedal tuning & transfer function refactor 24A #247

jr1221 opened this issue Dec 20, 2024 · 0 comments

Comments

@jr1221
Copy link
Contributor

jr1221 commented Dec 20, 2024

Description

Last year we had different sloped and offsetted sensors. This year we have two even sloped offset sensors. See ESF FSAE 2025 in Comp Documents -> Torque & Control Path security tab in Sharepoint.

Acceptance Criteria

  • All APPS rules are folllowed and commented with rule ID in calc_pedal_faults
  • All APPS rules are united tested to best of ability
  • New offsets are computed to return pedals to 0-100 ranges.

Proposed Solution

Re-implement the adjust_pedal_val's constants to account for our ESF settings. Further, ensure calc_pedal_faults will not be influenced by enw change, follow all torque security and faulting rules (APPS).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant