Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add little endian iee754 f32 decoding. #80

Open
jr1221 opened this issue Dec 10, 2024 · 0 comments
Open

Add little endian iee754 f32 decoding. #80

jr1221 opened this issue Dec 10, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@jr1221
Copy link
Contributor

jr1221 commented Dec 10, 2024

Description

We have big endian decoding. Lets get little endian decoding going as well. For this, a switch to from_be_bytes and from_le_bytes will be in order. We dont send bitaligned floats anyway.

Acceptance Criteria

Test and ensure can read both little endian floats (not endian swapped in C) and big endian floats.

Proposed Solution

Change the match statements to from_be_bytes and from_le_bytes, from_bits isnt needed.

@harrison-e harrison-e added the good first issue Good for newcomers label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants