Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scylla] - Fix batching logic #244

Open
Tracked by #256
jr1221 opened this issue Nov 21, 2024 · 0 comments · May be fixed by #262
Open
Tracked by #256

[Scylla] - Fix batching logic #244

jr1221 opened this issue Nov 21, 2024 · 0 comments · May be fixed by #262

Comments

@jr1221
Copy link
Contributor

jr1221 commented Nov 21, 2024

Description

Batching logic has a max instruction set of 65535, and with 4 instructions per INSERT the batch has a max messages of 64435/4. We need to optimize splitting the batch inserts while continuing to obey the upsert time.

Acceptance Criteria

  • New logic splits up inserts so there isnt any 1 item inserts

Proposed Solution

Split the items up using a division, where remainder is attached to one message, guarranteeing data over the limit wont be used.

Mocks

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant