Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string identifier for company ids #84

Open
dlech opened this issue Jul 14, 2022 · 6 comments
Open

string identifier for company ids #84

dlech opened this issue Jul 14, 2022 · 6 comments

Comments

@dlech
Copy link
Contributor

dlech commented Jul 14, 2022

It would be useful if companies had an "identifier" property like services and characteristics. This would allow programmatic lookup of CIDs by name. The name property doesn't seem useful for this as it could change over time.

@dinesharjani
Copy link
Collaborator

Yes, you're not wrong. But when we got started with this project, our goal was to get it to be as 'close as possible' to the Bluetooth spec - our goal was for this project to be adopted by the community, which I have to say it broadly has, at least by my expectations.

If you have a specific idea of how to extend the API, perhaps witha /v2 option and so on, let us know.

@dlech
Copy link
Contributor Author

dlech commented Jul 18, 2022

I thought the suggestion of adding an "identifier" property similar to attributes was very specific.

@dinesharjani
Copy link
Collaborator

Yes, but how would that work? What would the guidelines be? What would the values be for the current attributes covered? How would we fill the identifier for instances covered by Bluetooth SIG? I meant it in a more 'formal' sense.

@dlech
Copy link
Contributor Author

dlech commented Jul 18, 2022

The guidelines are the same as for the "identifier" property of attributes (reverse DNS), except it would only use the "com.example" part since it is just the company. If a CID name changes (e.g. the ones with "formerly...."), the identifier does not change. A subdomain could be added if two CIDs use the same top-level domain.

@reynoldslaw
Copy link

reynoldslaw commented Sep 23, 2023

Apple airtags show initially with no name on nrf connect 2.6.7 build 34 for ios. Once connected the name at the bottom updates as FindMy. Yet the name in the list cannot be filtered.

Another issue is in the RSSI tab, the colors on the left do not match the colors of the RSSI lines.

When selecting a single device, all RSSI lines turn grey, and the selected device also remains gray when it should be the only one in color.

The device advertises Apple Reserved Service so the best practice would be to identify the device as an Airtag.

@dinesharjani
Copy link
Collaborator

@reynoldslaw Apple has multiple Reserved Service(s). And since they're not documented / published in any one place (to my knowledge), they could potentially be changed, even though I agree that's not a likely thing. But I can look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants