Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add capability for extended taper of FV AM fixer #95

Open
gold2718 opened this issue Sep 8, 2023 · 0 comments
Open

Add capability for extended taper of FV AM fixer #95

gold2718 opened this issue Sep 8, 2023 · 0 comments
Assignees
@gold2718
Labels
enhancement New feature or request

Comments

@gold2718
Copy link

gold2718 commented Sep 8, 2023 •
edited
Loading

What is the feature/what would you like to discuss?

  • Specify a new tag for the camnor_phys external which contains the code to implement this change.
  • Add namelist variables fv_am_fix_taper, fv_am_fix_taper, and fv_am_fix_taper to control the extended taper.
  • Note, this is work from @tto061

Is there anyone in particular you want to be part of this conversation?

No response

Will this change (regression test) answers?

No

Will you be implementing this enhancement yourself?

Yes
@gold2718 gold2718 added the enhancement New feature or request label Sep 8, 2023
@gold2718 gold2718 self-assigned this Sep 8, 2023
@gold2718 gold2718 moved this to In Progress in NorESM Development Sep 8, 2023
@gold2718 gold2718 mentioned this issue Sep 12, 2023
Merged
gold2718 added a commit that referenced this issue Sep 21, 2023
@gold2718
Merge pull request #96 from gold2718/add_taper_fix
0384e57 
noresm_v6_cam6_3_123: Add taper fix

Summary: New version of CAM-Nor FV dycore with extended taper for AM fixer with supporting namelist changes
Contributors: tto061, gold2718
Reviewers: oyvindseland, tto061
Purpose of changes:  Add capability for extended taper of FV AM fixer (Issue #95) 
Github PR URL: #96
Changes made to build system: None
Changes made to the namelist: 
- fv_am_fix_taper: Added flag to taper the AM fixer
- fv_am_fix_tpr_h: Added height (pressure) at which to begin the taper
- fv_am_fix_tpr_w: Height (pressure) interval for fixer
Changes to the defaults for the boundary datasets: None
Substantial timing or memory changes: None
- Externals_CAM.cfg: New CAM-Nor-physics tag (containing code changes to implement AM fixer)
- bld/namelist_files/namelist_definition.xml: Added new namelist variables (see above)
Tested with aux_cam_noresm, all tests pass
Issues addressed by this PR:
closes #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gold2718 gold2718

Labels
enhancement New feature or request
Projects
NorESM Development
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gold2718